nova-cloud-controller not pushes ssh keys

[Michał Ajduk]

In some situations nova cloud controller never pushes SSH keys for live migration.

https://github.com/openstack/charm-nova-cloud-controller/blob/master/hooks/nova_cc_hooks.py#L702

Method _goal_state_achieved_for_relid always return false if units_so_far and all_units are out of order.

Example:
units_so_far = ['nova-compute/0', 'nova-compute/1', 'nova-compute/2', 'nova-compute/3', 'nova-compute/4', 'nova-compute/5', 'nova-compute/6']

target_units = ['nova-compute/3', 'nova-compute/2', 'nova-compute/5', 'nova-compute/0', 'nova-compute/6', 'nova-compute/4', 'nova-compute/1']

This returns false here:
https://github.com/openstack/charm-nova-cloud-controller/blob/master/hooks/nova_cc_hooks.py#L741

However there are 7 units required and 7 units present so the goal state is reached.

[Alex Kavanagh (ajkavanagh)]

Michael, thanks for the bug report, and an extremely good catch there! I'll put together a patch for this.

[Michał Ajduk (majduk)]

I've submitted patch already:
https://review.opendev.org/701804

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/701805

[OpenStack Infra (hudson-openstack)]

Change abandoned by Michal Ajduk (<email address hidden>) on branch: master
Review: https://review.opendev.org/701804
Reason: This overlaps with 701805

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/19.10
Review: https://review.opendev.org/701927

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/701805
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=0db6d59353ff34ca7c655214d17a2a790f77e377
Submitter: Zuul
Branch: master

commit 0db6d59353ff34ca7c655214d17a2a790f77e377
Author: Alex Kavanagh <email address hidden>
Date: Thu Jan 9 18:42:57 2020 +0000

    Fix _goal_state_achieved_for_relid() with unsorted lists

    Essentially, the functions returning the related units and expected
    units (for goal state) might not be sorted, something the author of
    the code (me) hadn't taken into account. This fixes that by comparing
    sorted lists.

    Change-Id: I5c7bfe39b80f103e95fd5105d2185a89975ec23c
    Closes-bug: #1859050

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/701927
Committed: https://git.openstack.org/cgit/openstack/charm-nova-cloud-controller/commit/?id=ab75b539ab7623312f56a55599dcab2fc943233f
Submitter: Zuul
Branch: stable/19.10

commit ab75b539ab7623312f56a55599dcab2fc943233f
Author: Alex Kavanagh <email address hidden>
Date: Thu Jan 9 18:42:57 2020 +0000

    Fix _goal_state_achieved_for_relid() with unsorted lists

    Essentially, the functions returning the related units and expected
    units (for goal state) might not be sorted, something the author of
    the code (me) hadn't taken into account. This fixes that by comparing
    sorted lists.

    Change-Id: Id6ca9fc756b0ef18d00863fa4641ab1c244db939
    Closes-bug: #1859050