a simple function should exist for setting a salted password in one step

[Rogan Hamby]

Right now the set_password function needs a few steps to allow a systems administrator to set a password. For convenience it would be nice to have a single function handle the salt and password in one step as the migrate password function does.

[Bill Erickson (berick)]

What I have locally. Can branch-ify.

-- utility sql for modifying user 'main' passwords
CREATE OR REPLACE FUNCTION actor.change_password (user_id INT, new_pw TEXT, pw_type TEXT DEFAULT 'main')
RETURNS VOID AS $$
DECLARE
    new_salt TEXT;
BEGIN
    SELECT actor.create_salt(pw_type) INTO new_salt;

    IF pw_type = 'main' THEN
        -- Only 'main' passwords are required to have
        -- the extra layer of MD5 hashing.
        PERFORM actor.set_passwd(
            user_id, pw_type, md5(new_salt || md5(new_pw)), new_salt
        );

    ELSE
        PERFORM actor.set_passwd(user_id, pw_type, new_pw, new_salt);
    END IF;
END;
$$ LANGUAGE 'plpgsql';

[Rogan Hamby (rogan-hamby)]

That's functionally identical to what Jason Etheridge and I have bene using locally too. So, whoever branchifies first.... wins? (maybe a complimentary beverage)

[Jason Stephenson (jstephenson)]

We've got the "same" function at CW MARS as well. Comes in real handy.

[Rogan Hamby (rogan-hamby)]

branch here: user/rogan/lp1858833_set_salted_password

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rogan/lp1858833_set_salted_password

[Bill Erickson (berick)]

Thanks, Rogan. Merged to master in prep for 3.6.