Logrotate limits parameter input can't use hourly

Bug #1858700 reported by Marc Methot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
Marc Methot

Bug Description

Currently LogrotateRotationInterval (tripleo-heat-templates master) does not allow for 'hourly' value.
This has been added to logrotate utility on May 13, 2013.
- https://github.com/logrotate/logrotate/commit/d21ca2591bef1b405459e1b31ebed26b5968fa5d

RHEL 7 also supports it.
- https://access.redhat.com/solutions/1362833

THT
- deployment/logrotate/logrotate-crond-container-puppet.yaml
~~~
  LogrotateRotationInterval:
    description: Configures rotation interval for containerized logrotate.
    type: string
    default: 'daily'
    constraints:
      - allowed_values: [ 'daily', 'weekly', 'monthly' ]
~~~

Adding 'hourly' to this list would not break the tripleo-puppet template either.
We also do not need to change the associated cron as we do not use the daily default one in the container.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/701464

Changed in tripleo:
assignee: nobody → Marc Methot (mb-methot)
status: New → In Progress
Changed in tripleo:
importance: Undecided → Low
milestone: none → ussuri-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/701464
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9f5ba23c839c4a905805f0325e8a8d84c8fa91eb
Submitter: Zuul
Branch: master

commit 9f5ba23c839c4a905805f0325e8a8d84c8fa91eb
Author: Marc Methot <email address hidden>
Date: Tue Jan 7 16:54:06 2020 -0500

    Adding hourly option to LogrotateRotationInterval parameter

    Change-Id: I40844e4a98f986e5f6132619c808b95bd6fecf7f
    Closes-Bug: #1858700

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 12.1.0

This issue was fixed in the openstack/tripleo-heat-templates 12.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.