ensure ceph-ansible installed role contradicts itself

Bug #1857460 reported by John Fulton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Francesco Pantano

Bug Description

The first task below confirms that I'm using a certain ceph-ansible repos to provide ceph-ansible.
The second task then fails tells me that I should use that repos.
These two tasks contradict themselves.

Note that on my undercloud ceph-ansible came from tripleo-centos-ceph-nautilus and I set that variable accordingly in tripleo-validations. FWIW, that's how tripleo-lab sets it up [1]

TASK [ceph : Get ceph-ansible repository] ***************************************************************************************************************************************************
task path: /home/stack/tripleo-validations/roles/ceph/tasks/ceph-ansible-installed.yaml:24
<localhost> ESTABLISH LOCAL CONNECTION FOR USER: stack
<localhost> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /tmp/ansible-${USER}/ansible-tmp-1577200912.85-62542618865115 `" && echo ansible-tmp-1577200912.85-62542618865115="` echo /tmp/ansible-${USER}/ansible-tmp-1577200912.85-62542618865115 `" ) && sleep 0'
Using module file /usr/lib/python2.7/site-packages/ansible/modules/commands/command.py
<localhost> PUT /home/stack/.ansible/tmp/ansible-local-425690mxVQDU/tmpWyiLKB TO /tmp/ansible-stack/ansible-tmp-1577200912.85-62542618865115/AnsiballZ_command.py
<localhost> EXEC /bin/sh -c 'chmod u+x /tmp/ansible-stack/ansible-tmp-1577200912.85-62542618865115/ /tmp/ansible-stack/ansible-tmp-1577200912.85-62542618865115/AnsiballZ_command.py && sleep 0'
<localhost> EXEC /bin/sh -c '/usr/bin/python2 /tmp/ansible-stack/ansible-tmp-1577200912.85-62542618865115/AnsiballZ_command.py && sleep 0'
<localhost> EXEC /bin/sh -c 'rm -f -r /tmp/ansible-stack/ansible-tmp-1577200912.85-62542618865115/ > /dev/null 2>&1 && sleep 0'
ok: [undercloud] => {
    "changed": false,
    "cmd": "yum info ceph-ansible | awk '/From repo/ {print $4}'",
    "delta": "0:00:00.916789",
    "end": "2019-12-24 15:21:53.884558",
    "invocation": {
        "module_args": {
            "_raw_params": "yum info ceph-ansible | awk '/From repo/ {print $4}'",
            "_uses_shell": true,
            "argv": null,
            "chdir": null,
            "creates": null,
            "executable": null,
            "removes": null,
            "stdin": null,
            "stdin_add_newline": true,
            "strip_empty_ends": true,
            "warn": true
        }
    },
    "rc": 0,
    "start": "2019-12-24 15:21:52.967769",
    "stderr": "",
    "stderr_lines": [],
    "stdout": "tripleo-centos-ceph-nautilus",
    "stdout_lines": [
        "tripleo-centos-ceph-nautilus"
    ]
}

TASK [ceph : Fail if ceph-ansible doesn't belong to the specified repo] *********************************************************************************************************************
task path: /home/stack/tripleo-validations/roles/ceph/tasks/ceph-ansible-installed.yaml:29
fatal: [undercloud]: FAILED! => {
    "changed": false,
    "msg": "Make sure ceph-ansible package is installed from tripleo-centos-ceph-nautilus"
}

[1] https://github.com/cjeanner/tripleo-lab/blob/67358e6b1376283c766509adf5aecb11becfcf8f/roles/undercloud/tasks/packages.yaml#L24

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (master)

Fix proposed to branch: master
Review: https://review.opendev.org/701337

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/701338

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (master)

Reviewed: https://review.opendev.org/701337
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=eb62c8f95e3ff32a11014c6887a4fe531ebd6f53
Submitter: Zuul
Branch: master

commit eb62c8f95e3ff32a11014c6887a4fe531ebd6f53
Author: Francesco Pantano <email address hidden>
Date: Tue Jan 7 09:02:20 2020 +0100

    Fix ceph-ansible repo check

    This commit fix the order of the "when" condition items when
    the ceph-ansible repo is evaluated.

    Change-Id: I5341dc3894aa672fda746cdd81e16712ee312c52
    Closes-Bug: 1857460

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/701538

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/train)

Reviewed: https://review.opendev.org/701538
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=dc4fd109a6f04ff007a2842284622ecad4224798
Submitter: Zuul
Branch: stable/train

commit dc4fd109a6f04ff007a2842284622ecad4224798
Author: Francesco Pantano <email address hidden>
Date: Tue Jan 7 09:02:20 2020 +0100

    Fix ceph-ansible repo check

    This commit fix the order of the "when" condition items when
    the ceph-ansible repo is evaluated.

    Change-Id: I5341dc3894aa672fda746cdd81e16712ee312c52
    Closes-Bug: 1857460
    (cherry picked from commit eb62c8f95e3ff32a11014c6887a4fe531ebd6f53)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/703921

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/703926

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/703928

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/queens)

Reviewed: https://review.opendev.org/703928
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=1ac55cd6f95f422284ef2bdf3eb62bca15874fe1
Submitter: Zuul
Branch: stable/queens

commit 1ac55cd6f95f422284ef2bdf3eb62bca15874fe1
Author: Francesco Pantano <email address hidden>
Date: Fri Jan 24 16:28:14 2020 +0100

    Sync 'validations/ceph-ansible-installed.yaml' with the new role

    Closes-Bug: 1857460
    Change-Id: Ib80b55cbd0d4b4dd83d8dbc9dc2afe1d6df2ede5
    (cherry picked from commit 716a3083232ca137ed617ada73f49a6fe5a6869b)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/rocky)

Reviewed: https://review.opendev.org/703926
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=1bdafd5281bd0a2b48551690590711c0d75149fe
Submitter: Zuul
Branch: stable/rocky

commit 1bdafd5281bd0a2b48551690590711c0d75149fe
Author: Francesco Pantano <email address hidden>
Date: Thu Jan 30 12:16:13 2020 +0100

    Sync 'validations/ceph-ansible-installed.yaml' with the new role

    Closes-Bug: 1857460
    Change-Id: Ib80b55cbd0d4b4dd83d8dbc9dc2afe1d6df2ede5
    (cherry picked from commit 716a3083232ca137ed617ada73f49a6fe5a6869b)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/701338
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=020ad398d5c921dbdd184a499f1214b1f15212f9
Submitter: Zuul
Branch: master

commit 020ad398d5c921dbdd184a499f1214b1f15212f9
Author: Francesco Pantano <email address hidden>
Date: Tue Jan 7 09:24:06 2020 +0100

    Add ceph_ansible_repo variable on ceph-base

    In order to properly evaluate the ceph-ansible
    repo using validations, this change adds the
    "ceph_ansible_repo" variable to point to the
    correct default tripleo ceph repo.

    Change-Id: Ib398bbb5765fbe87f8e37d7a58b356f7d4670c87
    Related-Bug: 1857460

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 12.1.0

This issue was fixed in the openstack/tripleo-validations 12.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/708700

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/708700
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=dc4ecf797468079747ce206c2b02433fb07c82c1
Submitter: Zuul
Branch: stable/train

commit dc4ecf797468079747ce206c2b02433fb07c82c1
Author: Francesco Pantano <email address hidden>
Date: Tue Jan 7 09:24:06 2020 +0100

    Add ceph_ansible_repo variable on ceph-base

    In order to properly evaluate the ceph-ansible
    repo using validations, this change adds the
    "ceph_ansible_repo" variable to point to the
    correct default tripleo ceph repo.

    Change-Id: Ib398bbb5765fbe87f8e37d7a58b356f7d4670c87
    Related-Bug: 1857460
    (cherry picked from commit 020ad398d5c921dbdd184a499f1214b1f15212f9)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/stein)

Reviewed: https://review.opendev.org/703921
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=11cec2bfa9f293eadc0b45f02382bef61c142d9c
Submitter: Zuul
Branch: stable/stein

commit 11cec2bfa9f293eadc0b45f02382bef61c142d9c
Author: Francesco Pantano <email address hidden>
Date: Tue Jan 7 09:02:20 2020 +0100

    Add an additional validation to check ceph-ansible repository

    In order to address the ceph-ansible potential cross-shipping,
    this change adds an extra task to validate the repository that
    should be used to install ceph-ansible in the undercloud.
    If ceph-ansible is not installed or the repo doesn't match the
    specified one, this validation raise an error.

    Change-Id: Ib80b55cbd0d4b4dd83d8dbc9dc2afe1d6df2ede5
    Closes-Bug: 1857460
    (cherry picked from commit 329f740d109b87105eac36fade70c69c15781a38)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 11.4.0

This issue was fixed in the openstack/tripleo-validations 11.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations rocky-eol

This issue was fixed in the openstack/tripleo-validations rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations queens-eol

This issue was fixed in the openstack/tripleo-validations queens-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations stein-eol

This issue was fixed in the openstack/tripleo-validations stein-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.