calico-dhcp-agent doesn't add domain parameter to dnsmasq

Bug #1856909 reported by Justin Pacheco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-calico
Fix Released
Undecided
Justin Pacheco

Bug Description

neutron 13.0.4 introduced a change to the parent class dhcp.Dnsmasq which is inherited by DnsmasqRouted in calico-dhcp-agent. This change removed the member variable self.dns_domain which is used by calico-dhcp-agent to correctly set the --domain dnsmasq parameter to the value set in /etc/neutron/neutron.conf. Without this parameter, vms cannot get their fqdn from dhcp on boot

Changed in networking-calico:
assignee: nobody → Justin Pacheco (jpacheco39)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-calico (master)

Fix proposed to branch: master
Review: https://review.opendev.org/699891

Changed in networking-calico:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-calico (master)

Reviewed: https://review.opendev.org/699891
Committed: https://git.openstack.org/cgit/openstack/networking-calico/commit/?id=594cf28fb0359c1abf6da1022574be5ddd710a7b
Submitter: Zuul
Branch: master

commit 594cf28fb0359c1abf6da1022574be5ddd710a7b
Author: Justin Pacheco <email address hidden>
Date: Wed Dec 18 19:29:06 2019 -0500

    calico-dhcp-agent dnsmasq domain parameter fix

    neutron 13.0.4 introduced a change to the parent class dhcp.Dnsmasq
    which is inherited by DnsmasqRouted in calico-dhcp-agent. This
    change removed the member variable self.dns_domain which is used by
    calico-dhcp-agent to correctly set the --domain dnsmasq parameter to
    the value set in /etc/neutron/neutron.conf

    this patch updates the subclass DnsmasqRouted to look for the dns_domain
    parameter in the correct location which works with both neutron 13.0.2 and
    13.0.4

    Change-Id: I7a14adcc540408dd4493114a429883ac6c8fe6af
    Closes-Bug: #1856909

Changed in networking-calico:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.