OpenILS::Utils::ISBN doesn't seem to be used for anything

[Jane Sandberg]

Using some quick grepping, I haven't found any code (apart from a test) that uses OpenILS::Utils::ISBN. It looks like a lot of the Perl code just uses Business::ISBN directly. Maybe we could deprecate OpenILS::Utils::ISBN?

[Galen Charlton (gmc)]

I checked and agree that it isn't used and that it may as well be removed.

[Jane Sandberg (sandbergja)]

Here is a branch to remove it: user/sandbergja/lp1856906_remove_openils_utils_isbn

[Josh Stompro (u-launchpad-stompro-org)]

Jane's branch was included in the https://bugsquash.mobiusconsortium.org/eg/staff server for bug fixing week.

But I'm not sure how to test the removal of something like that. Maybe whoever setup the mobius server can attest to the removal not causing any problems for install? And that the test that was changed still runs ok?

Josh

[Blake GH (bmagic)]

I can attest that it didn't break anything. I figured by virtue of the server being up and people testing other bugs on the same machine would be the "proof". Signed off here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/blake/lp1856906_remove_openils_utils_isbn

[Galen Charlton (gmc)]

Pushed for inclusion in 3.9-beta. Thanks, Jane and Blake!