Remove deprecated open-ils.circ.renew.auto API

[Jason Stephenson]

The fix for bug 1835085 deprecated the open-ils.circ.renew.auto API that was added in Evergreen 3.2. The release notes indicated that this API call would be removed in Evergreen 3.5.0. This bug is to track that and provide a place for the removal branch.

[Jason Stephenson (jstephenson)]

Branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1856868-remove-open-ils.circ.renew.auto

[Mike Risher (mrisher)]

I did some greps on our codebase and it looks like calls to open-ils.circ.renew.auto have been removed. I see a note saying it's been deprecated, and that's great. My only concern is line 251 of Circulate.pm. Line 251 says:

"$circulator->auto_renewal(1) if $api =~ /renew.auto/;"

Can someone who knows PERL better than I confirm that line 251 is not part of the old deprecated code? If we can confirm line 251 belongs there I'm happy to sign off.

[Mike Risher (mrisher)]

Turns out I was looking at the wrong file. I was looking at the Circulate.pm file in /perlmods/blib/ and not looking at Jason's changes. Line 251 referenced above has already been removed. I can't find any lingering deprecated code, so I'm going to call this a success.

I consent to sign off on this with my name, Mike Risher, and email <email address hidden>

[Galen Charlton (gmc)]

Pushed for inclusion in 3.8. Thanks, Jason and Mike!

(Sorry Jane, I didn't notice that you had assigned yourself to the bug until after I pushed the patch.)