scale: failures during scale down

[Emilien Macchi]

Originally reported here: https://bugzilla.redhat.com/show_bug.cgi?id=1693838

When scaling down the computes, some tasks are wrongly skipped and facts not refreshed, making the scale down to fail and the nova compute not teared-down.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/698515

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/698784

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698515
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=fe6b235e5f8f5e53356d3ce4dd5be16a862a7296
Submitter: Zuul
Branch: master

commit fe6b235e5f8f5e53356d3ce4dd5be16a862a7296
Author: Emilien Macchi <email address hidden>
Date: Wed Dec 11 10:27:26 2019 -0500

    scale: fixes for compute scale down

    - Force fact gathering so that we're ensured to have the proper FQDN
    - Update start squence so that our scale down process is not starting
      from irrelevant steps
    - correct list evaluation. The compute service argument should have one
      item in the list. Prior to this change it was expecting zero items,
      which was causing the removal tasks to skip.

    Co-Authored-By: "Cedric Jeanneret (Tengu) <email address hidden>"
    Co-Authored-By: "Emilien Macchi <email address hidden>"
    Co-Authored-By: "Kevin Carter (cloudnull) <email address hidden>"

    Change-Id: I7c1615685718924e872a2f9173b15c63bba8c482
    Closes-Bug: #1856062

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/698784
Reason: Clearing the gate now, see https://bugs.launchpad.net/tripleo/+bug/1856864
Do not restore the patch yet, I'll take care of it when the gate is back online.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698784
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7a4015f220f5d573c237cdec373eb68bf2fe7681
Submitter: Zuul
Branch: stable/train

commit 7a4015f220f5d573c237cdec373eb68bf2fe7681
Author: Emilien Macchi <email address hidden>
Date: Wed Dec 11 10:27:26 2019 -0500

    scale: fixes for compute scale down

    - Force fact gathering so that we're ensured to have the proper FQDN
    - Update start squence so that our scale down process is not starting
      from irrelevant steps
    - correct list evaluation. The compute service argument should have one
      item in the list. Prior to this change it was expecting zero items,
      which was causing the removal tasks to skip.

    Co-Authored-By: "Cedric Jeanneret (Tengu) <email address hidden>"
    Co-Authored-By: "Emilien Macchi <email address hidden>"
    Co-Authored-By: "Kevin Carter (cloudnull) <email address hidden>"

    Change-Id: I7c1615685718924e872a2f9173b15c63bba8c482
    Closes-Bug: #1856062

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.1.0 release.