[Train] HA: rabbitmq_init_bundle not restart on stack update as expected

[Damien Ciabrini]

Starting in Train, a rabbitmq HA service refactoring [1] and a later unsuccessful fix [2] left the service unable to restart container "rabbitmq_init_bundle" on every stack update or minor update.

We used to originally create rabbitmq_init_bundle with an environment variable TRIPLEO_DEPLOY_IDENTIFIER whose value always changes during deploy/update, so paunch would always restart this container.

This variable is now gone, so we lost the expected behaviour.

[1] I894f339cdf03bc2a93c588f826f738b0b851a3ad
[2] I139c2c276c8f532d37fceafe06f9547048e76906

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/698041

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698041
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=82408e4b8add9da281e7cc51b3743ecd1d9efe43
Submitter: Zuul
Branch: master

commit 82408e4b8add9da281e7cc51b3743ecd1d9efe43
Author: Damien Ciabrini <email address hidden>
Date: Mon Dec 9 17:24:14 2019 +0100

    Ensure rabbitmq deployment container is restarted at every update

    In [1] we lost the ability to restart deployment containers such as
    rabbitmq_bootstrap and rabbitmq_init_bundle every time a stack update
    or minor update is run. A fix for it [2] was attempted but was only
    partial so not working.

    Make sure we reintroduce variable TRIPLEO_DEPLOY_IDENTIFIER in all
    the rabbitmq deployment containers (HA and non-HA) to make sure they
    get restarted as expected at every update.

    [1] I894f339cdf03bc2a93c588f826f738b0b851a3ad
    [2] I139c2c276c8f532d37fceafe06f9547048e76906

    Change-Id: I131a905b62cd990deee1ae6aa81ab2560c98a7c8
    Closes-Bug: #1855732

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/698451

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698451
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3a02caa86b45c70f2c171683dd19358c59d09c4b
Submitter: Zuul
Branch: stable/train

commit 3a02caa86b45c70f2c171683dd19358c59d09c4b
Author: Damien Ciabrini <email address hidden>
Date: Mon Dec 9 17:24:14 2019 +0100

    Ensure rabbitmq deployment container is restarted at every update

    In [1] we lost the ability to restart deployment containers such as
    rabbitmq_bootstrap and rabbitmq_init_bundle every time a stack update
    or minor update is run. A fix for it [2] was attempted but was only
    partial so not working.

    Make sure we reintroduce variable TRIPLEO_DEPLOY_IDENTIFIER in all
    the rabbitmq deployment containers (HA and non-HA) to make sure they
    get restarted as expected at every update.

    [1] I894f339cdf03bc2a93c588f826f738b0b851a3ad
    [2] I139c2c276c8f532d37fceafe06f9547048e76906

    Change-Id: I131a905b62cd990deee1ae6aa81ab2560c98a7c8
    Closes-Bug: #1855732
    (cherry picked from commit 82408e4b8add9da281e7cc51b3743ecd1d9efe43)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.1.0 release.