fix Play button connections to be reliable with all Cue modes

Bug #1855620 reported by ronso0
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
High
ronso0

Bug Description

As noticed in LateNight redesign ptII, the play toggle decoration is sometimes not applied correctly when it's toggled repeatedly quickly.
https://github.com/mixxxdj/mixxx/pull/2342#issuecomment-562957300

Let's clean up how '[group],play' and '[group],play_indicator' are used in skins and also make sure the skin controls always receive the correct status with every Cue mode.

Tags: skin
Be (be.ing)
Changed in mixxx:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
ronso0 (ronso0) wrote :
description: updated
Changed in mixxx:
assignee: nobody → ronso0 (ronso0)
Revision history for this message
Daniel Schürmann (daschuer) wrote :

Is this finally fixed here?
https://github.com/mixxxdj/mixxx/pull/2619

Revision history for this message
ronso0 (ronso0) wrote :

Seems so, I can't reproduce it anymore.

Changed in mixxx:
milestone: none → 2.3.0
status: Confirmed → Fix Committed
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9822

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.