Reapplying item template with alert or note results in multiple alerts and/or notes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Undecided
|
Unassigned | ||
3.10 |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
If an item template that includes an item alert or item note is applied to an item multiple times, the alert and/or note is added to that item multiple times. There is no visible indicator that the alert and/or note now exist more than once. (Actually, there is no indicator that *any* alert or note exist for that item.) See related bug: https:/
Our libraries typically use item templates when cataloging. It is easy to reapply a template inadvertently. Additionally, a user may modify a template to change one or more attributes (e.g. loan duration, shelving location) before reapplying it to edit a batch of items. In this case, all of those items will have the item note and/or alert duplicated.
At check in and/or check out, depending upon the type of alert, one alert appears, but the alert text is repeated multiple times. This is not as bad as having the alert pop-up multiple times, but is still unnecessary and potentially confusing.
tags: | added: itemtemplates |
tags: |
added: cat-templates removed: itemtemplates |
Changed in evergreen: | |
milestone: | none → 3.12-beta |
Changed in evergreen: | |
assignee: | nobody → Michele Morgan (mmorgan) |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
EG 3.11 Angular volcopy editor, here is working branch for this issue.
user/stompro/ lp1855144_ angular_ volcopy_ template_ skipdupitemaler ts
https:/ /git.evergreen- ils.org/ ?p=working/ Evergreen. git;a=shortlog; h=refs/ heads/user/ stompro/ lp1855144_ angular_ volcopy_ template_ skipdupitemaler ts
This checks for existing alerts that match the same type, note and temporary status and skips adding them again for each copy.
So if you are editing 10 copies, and half of them have the alert already, then only the ones without the alert would get it applied.
I based this off of the branch for Bug 1983156, but I think it can be applied on it's own.
Testing Notes:
1. Create a copy template that includes one or more item alerts.
Use the AngularJS holdings editor to do so Admin -> local admin ->
Holdings Template Editor.
2. After saving, log out and back in. I've noticed my template
edits in the AngularJS interface sometimes don't make it
to the Angular interface witout logging out and back in.
3. Edit an item in the Angular holdings editor en-US/staff/ cat/volcopy/ holdings/ item/xxxx
/eg2/
4. Apply the template several times and save the copy.
5. Check for duplicate item alerts.
There will also be a console for message about duplicate
alerts being detected when applying the template.