update prepare command always saving config to overcloud-config container regardless of stack name

[James Slagle]

The update prepare command calls the get_config workflow from workbooks/package_update.py. This workflow calls the tripleo.config.get_overcloud_config action, but it only passes in the container name, not the container_config name.

This means the action ends using overcloud-config, even if the stack name is called something not overcloud. This can cause issues with multi-stack and the multiple overcloud features, or just using a non default overcloud name.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697174

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697188

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697174
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=12ecf6c85d6db28794e5ce04c2c8a29d6c9fc53c
Submitter: Zuul
Branch: master

commit 12ecf6c85d6db28794e5ce04c2c8a29d6c9fc53c
Author: James Slagle <email address hidden>
Date: Tue Dec 3 14:58:12 2019 -0500

    Pass container_config to config actions

    This patch updates the get_config and update_nodes workflows to pass in
    the container_config name into the get_overcloud_config/download_config
    actions.

    When the container_config name is not passed, the default
    overcloud-config is used. This means the correct config is not used if
    the stack name is not overcloud as is often the case with multiple
    overclouds or multi-stack.

    Change-Id: Id6b4a5913141fc558c40f2cfd29f5e0741544ab4
    Closes-Bug: #1854991

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.opendev.org/697188
Reason: Clearing the gate now, see https://bugs.launchpad.net/tripleo/+bug/1856864
Do not restore the patch yet, I'll take care of it when the gate is back online.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/697188
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=819dab257d5b671f3194792c111ece7b4ecaab39
Submitter: Zuul
Branch: master

commit 819dab257d5b671f3194792c111ece7b4ecaab39
Author: James Slagle <email address hidden>
Date: Tue Dec 3 16:51:04 2019 -0500

    Pass container name to update_nodes workflow

    The container name needs to be passed with the stack name value to the
    update_nodes workflow so that the right config container is used during
    the update.

    Previously, this was not an issue since all update actions just
    defaulted to overcloud-config even if the stack name wasn't overcloud.

    However, with the multiple overclouds feature and the multi-stack
    feature, we need to make sure the right config container is used that
    matches the stack name.

    Closes-Bug: #1854991
    Depends-On: Id6b4a5913141fc558c40f2cfd29f5e0741544ab4
    Change-Id: Ib25d8f8fbfde8fb13bd6518fd2383b7e3ae7abee

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/700050

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/700051

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/700050
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=1a8ec6fea8e7e8195e1327e3d1f1cd1e1d63c305
Submitter: Zuul
Branch: stable/train

commit 1a8ec6fea8e7e8195e1327e3d1f1cd1e1d63c305
Author: James Slagle <email address hidden>
Date: Tue Dec 3 14:58:12 2019 -0500

    Pass container_config to config actions

    This patch updates the get_config and update_nodes workflows to pass in
    the container_config name into the get_overcloud_config/download_config
    actions.

    When the container_config name is not passed, the default
    overcloud-config is used. This means the correct config is not used if
    the stack name is not overcloud as is often the case with multiple
    overclouds or multi-stack.

    Change-Id: Id6b4a5913141fc558c40f2cfd29f5e0741544ab4
    Closes-Bug: #1854991
    (cherry picked from commit 12ecf6c85d6db28794e5ce04c2c8a29d6c9fc53c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/700051
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=585fb2816ccc5b69d33ccc911cb78751330760a6
Submitter: Zuul
Branch: stable/train

commit 585fb2816ccc5b69d33ccc911cb78751330760a6
Author: James Slagle <email address hidden>
Date: Tue Dec 3 16:51:04 2019 -0500

    Pass container name to update_nodes workflow

    The container name needs to be passed with the stack name value to the
    update_nodes workflow so that the right config container is used during
    the update.

    Previously, this was not an issue since all update actions just
    defaulted to overcloud-config even if the stack name wasn't overcloud.

    However, with the multiple overclouds feature and the multi-stack
    feature, we need to make sure the right config container is used that
    matches the stack name.

    Closes-Bug: #1854991
    Depends-On: Id6b4a5913141fc558c40f2cfd29f5e0741544ab4
    Change-Id: Ib25d8f8fbfde8fb13bd6518fd2383b7e3ae7abee
    (cherry picked from commit 819dab257d5b671f3194792c111ece7b4ecaab39)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 11.3.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 13.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-common 12.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.4.0 release.