stein tripleo-ci-centos-7-undercloud-containers is broken (tempest-setup.sh)

[Michele Baldessari]

Examples:
https://zuul.opendev.org/t/openstack/build/0c868857f11547a3a569ef09a934ee13

and:
https://zuul.opendev.org/t/openstack/build/fa22fab0cd114a70ac688b1fe24247ca

The failure is around tempest (deploy succeeds) and it's (maybe wrong) invocation:
https://zuul.opendev.org/t/openstack/build/0c868857f11547a3a569ef09a934ee13/log/job-output.txt#4605-4619 has:
2019-11-30 12:49:41.092183 | primary |
2019-11-30 12:49:41.092523 | primary | TASK [validate-tempest : Execute tempest] **************************************
2019-11-30 12:49:41.127267 | primary | Saturday 30 November 2019 12:49:41 +0000 (0:00:00.149) 0:00:36.146 *****
2019-11-30 12:50:09.025813 | primary | fatal: [undercloud]: FAILED! => {
2019-11-30 12:50:09.026181 | primary | "changed": true,
2019-11-30 12:50:09.026671 | primary | "cmd": "set -o pipefail && /home/zuul/tempest-setup.sh 2>&1 | awk '{ print strftime(\"%Y-%m-%d %H:%M:%S |\"), $0; fflush(); }' > tempest.log\n",
2019-11-30 12:50:09.027177 | primary | "delta": "0:00:26.835652",
2019-11-30 12:50:09.027382 | primary | "end": "2019-11-30 12:50:08.996836",
2019-11-30 12:50:09.027469 | primary | "rc": 2,
2019-11-30 12:50:09.027628 | primary | "start": "2019-11-30 12:49:42.161184"
2019-11-30 12:50:09.027675 | primary | }
2019-11-30 12:50:09.027739 | primary |
2019-11-30 12:50:09.027821 | primary | MSG:
2019-11-30 12:50:09.027868 | primary |
2019-11-30 12:50:09.027968 | primary | non-zero return code
2019-11-30 12:50:09.028043 | primary | ...ignoring

B) And then we also have:
2019-11-30 12:50:12.516322 | primary | TASK [validate-tempest : Generate testrepository.subunit results file] *********
2019-11-30 12:50:12.537540 | primary | Saturday 30 November 2019 12:50:12 +0000 (0:00:00.785) 0:01:07.556 *****
2019-11-30 12:50:14.095170 | primary | fatal: [undercloud]: FAILED! => {
2019-11-30 12:50:14.095453 | primary | "changed": true,
2019-11-30 12:50:14.095893 | primary | "cmd": "set -o pipefail && python2 -m stestr.cli last --subunit | subunit-1to2 > /home/zuul/tempest/testrepository.subunit\n",
2019-11-30 12:50:14.096533 | primary | "delta": "0:00:00.896036",
2019-11-30 12:50:14.096701 | primary | "end": "2019-11-30 12:50:14.068562",
2019-11-30 12:50:14.096783 | primary | "rc": 1,
2019-11-30 12:50:14.096941 | primary | "start": "2019-11-30 12:50:13.172526"
2019-11-30 12:50:14.096987 | primary | }
2019-11-30 12:50:14.097084 | primary | MSG:
2019-11-30 12:50:14.097225 | primary | non-zero return code

The error is need a wrong tempest invocation:
Fromhttps://9d906e117ebdecd5e5c9-bfbfd8db497e7d54c8b9e3b8f437fb98.ssl.cf2.rackcdn.com/696652/1/check/tripleo-ci-centos-7-undercloud-containers/0c86885/logs/undercloud/home/zuul/tempest.log.txt.gz

2019-11-30 12:50:08 | usage: tempest run [-h] [--workspace WORKSPACE]
2019-11-30 12:50:08 | [--workspace-path WORKSPACE_PATH]
2019-11-30 12:50:08 | [--config-file CONFIG_FILE] [--smoke | --regex REGEX]
2019-11-30 12:50:08 | [--black-regex BLACK_REGEX]
2019-11-30 12:50:08 | [--whitelist-file WHITELIST_FILE]
2019-11-30 12:50:08 | [--blacklist-file BLACKLIST_FILE] [--load-list LOAD_LIST]
2019-11-30 12:50:08 | [--list-tests] [--concurrency CONCURRENCY]
2019-11-30 12:50:08 | [--parallel | --serial] [--save-state] [--subunit]
2019-11-30 12:50:08 | [--combine]
2019-11-30 12:50:08 | tempest run: error: unrecognized arguments: on undercloud, undercloud: True}|{test: tempest.api.network.test_floating_ips.FloatingIPTestJSON, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.servers, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_aggregates_negative.AggregatesAdminNegativeTestJSON.test_aggregate_add_existent_host, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_aggregates_negative.AggregatesAdminNegativeTestJSON.test_aggregate_add_host_as_user, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_aggregates_negative.AggregatesAdminNegativeTestJSON.test_aggregate_remove_host_as_user, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_create_server.ServersWithSpecificFlavorTestJSON, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_aggregates.AggregatesAdminTestJSON, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_create_server.ServersWithSpecificFlavorTestJSON, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_hypervisor, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_hypervisor_negative, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_delete_server, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_hosts.HostsAdminTestJSON.test_show_host_detail, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_servers, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_simple_tenant_usage, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_servers_negative, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.floating_ips, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_server_diagnostics, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.admin.test_server_diagnostics_negative, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.images, reason: Running on undercloud, undercloud: True}|{test: tempest.api.network.admin.test_external_networks_negative, reason: Running on undercloud, undercloud: True}|{test: tempest.api.network.admin.test_floating_ips_admin_actions, reason: Running on undercloud, undercloud: True}|{test: tempest.api.network.admin.test_routers, reason: Running on undercloud, undercloud: True}|{test: tempest.api.network.admin.test_routers_negative, reason: Running on undercloud, undercloud: True}|{test: tempest.api.network.test_floating_ips_negative, reason: Running on undercloud, undercloud: True}|{test: tempest.api.network.test_networks.NetworksIpV6Test.test_external_network_visibility, reason: Running on undercloud, undercloud: True}|{test: tempest.api.network.admin.test_ports, reason: Running on undercloud, undercloud: True}|{test: tempest.api.compute.security_groups.test_security_groups.SecurityGroupsTestJSON, reason: Running on undercloud, undercloud: True}|{test: tempest.api.identity.admin.v3.test_roles.RolesV3TestJSON, reason: Running on undercloud, undercloud: True}

The quoting in https://9d906e117ebdecd5e5c9-bfbfd8db497e7d54c8b9e3b8f437fb98.ssl.cf2.rackcdn.com/696652/1/check/tripleo-ci-centos-7-undercloud-containers/0c86885/logs/undercloud/home/zuul/tempest-setup.sh seems a bit messed up from the looks of it

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/696811

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/696811
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=07e161579b7c7fb852eedd0e36c2ad3a668ded6b
Submitter: Zuul
Branch: master

commit 07e161579b7c7fb852eedd0e36c2ad3a668ded6b
Author: Chandan Kumar (raukadah) <email address hidden>
Date: Mon Dec 2 08:48:20 2019 +0530

    Load os_tempest skiplist only train release onwards

    https://review.opendev.org/694719 moves fs027 to os_tempest
    and it breaks the tempest_test_regex for stein releases for
    validate-tempest as in else clause os_tempest blacklist is
    passed. Making it conditional fixes the issue.

    Closes-Bug: #1854612

    Change-Id: I33a818228e3366c29bc38719978673afd15bff9b
    Signed-off-by: Chandan Kumar (raukadah) <email address hidden>