'nova_cephx_raw_key' is undefined when using external ceph and nova_backend is not rbd

[Andrei Nistor]

**Bug Report**

What happened:
Upgrade from stein to train failed with the following error:

TASK [nova-cell : Pushing secrets key for libvirt] *****************************************************************************************************************************************************************************************************************************
fatal: [jf28-r16.ams1]: FAILED! => {"msg": "'nova_cephx_raw_key' is undefined"}
fatal: [jf28-r17.ams1]: FAILED! => {"msg": "'nova_cephx_raw_key' is undefined"}

How to reproduce it (minimal and precise):
Upgrade from stein to train with external ceph but with nova_backend_ceph = False. Probably affects new deployments as well.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/695933

[Mark Goddard (mgoddard)]

Introduced in this patch, which was backported to Stein: https://review.opendev.org/#/c/689753/2/ansible/roles/nova-cell/tasks/external_ceph.yml

The variable 'nova_cephx_raw_key' was previously always defined as it was registered. Switched to a set_fact and it is now sometimes undefined.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/695933
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=6ff633723067ecfa3644645e7cf8fd2216be616a
Submitter: Zuul
Branch: master

commit 6ff633723067ecfa3644645e7cf8fd2216be616a
Author: Andrei Nistor <email address hidden>
Date: Mon Nov 25 15:27:56 2019 +0000

    Fix 'nova_cephx_raw_key' is undefined

    When using external ceph without nova integration, kolla-ansible fails
    because 'nova_cephx_raw_key' is undefined.
    This patch fixes the issue by applying the 'default' filter to
    prevent failure on undefined.
    The change in behavior was introduced by [1].

    [1] https://review.opendev.org/689753
    commit 44709f413246a05b891f250e88c43226e1f1b0c9

    Change-Id: I2fdca1a6a78e78623733a387a2d8c7e29d449083
    Closes-Bug: #1853862
    Co-Authored-By: Mark Goddard <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/696341

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/696342

[OpenStack Infra (hudson-openstack)]

Change abandoned by Mark Goddard (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/696342
Reason: Not relevant

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/696341
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=424382db39e77e472d8f1e3a426658b617570694
Submitter: Zuul
Branch: stable/train

commit 424382db39e77e472d8f1e3a426658b617570694
Author: Andrei Nistor <email address hidden>
Date: Mon Nov 25 15:27:56 2019 +0000

    Fix 'nova_cephx_raw_key' is undefined

    When using external ceph without nova integration, kolla-ansible fails
    because 'nova_cephx_raw_key' is undefined.
    This patch fixes the issue by applying the 'default' filter to
    prevent failure on undefined.
    The change in behavior was introduced by [1].

    [1] https://review.opendev.org/689753
    commit 44709f413246a05b891f250e88c43226e1f1b0c9

    Change-Id: I2fdca1a6a78e78623733a387a2d8c7e29d449083
    Closes-Bug: #1853862
    Co-Authored-By: Mark Goddard <email address hidden>
    (cherry picked from commit 6ff633723067ecfa3644645e7cf8fd2216be616a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 9.0.0.0rc2 release candidate.