Overzealous warning when creating new board

[Ian McInerney]

When running pcbnew in standalone mode, if you have a board open and saved, clicking on the new board menu item will give a dialog saying that the current board will be lost. It does this even if there have been no modifications since the last time the board was saved.

This warning should be modified to warn the user if there are unsaved changes (and maybe give the option to save the board then), and say that it will be closed. Saying that the board will be lost is a very drastic warning if the board is actually saved to disk already, and therefore is still openable from the disk (saying it will be lost makes it sound like you will not be able to recover it).

Application: Pcbnew
Version: (5.99.0-397-g3c828750c-dirty), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.65.3 OpenSSL/1.1.1c-fips zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.9.0/openssl/zlib nghttp2/1.38.0
Platform: Linux 5.1.18-300.fc30.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Nov 19 2019 17:30:36
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.65.3
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=ON
    KICAD_SANITIZE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision f7ded3040cb6d25cb934a712c5b355c45e14ef0a
https://git.launchpad.net/kicad/patch/?id=f7ded3040cb6d25cb934a712c5b355c45e14ef0a

[Ian McInerney (imcinerney)]

I've change master to now prompt to save the board if it has been modified and to notify the user that the board will be closed if it hasn't (but there is a board open). These new messages should be better than the one we had before.

I am not sure if it is actually worth backporting the fix to the 5.1 branch. This is more of a usability annoyance than a bug. If someone feels strongly that it should be backported, let me know.

[Wayne Stambaugh (stambaughw)]

@Ian, I think cherry picking this to 5.1 is fairly low risk so please do so when you get a chance.