ipv6 server address connection failure using redfishtool:Transport: Fatal exception trying to connect to rhost. Error:Failed

[Anujeyan Manokeran]

Brief Description
-----------------
Connection failure using redfishtool on IPv6 server address in ipv6 lab configuration . Below cli was failing to connect using refishtool to the server. Verified on tuxlab2 with redifish tool using culr command with ipv6 address it was working . Eg: sudo curl -X GET -k https://[2620:10a:a001:a102::133]/redfish/v1/ -H 'Content-Type':'application/json;charset=utf-8' -H 'Accept':'application/json;charset=utf-8' | python -mjson.tool . But on a controller it was failing.

Cli failure on controller :
redfishtool -r "2620:10a:a001:a102::133" -u sysadmin -p Li69nux* Systems get
  redfishtool:Transport: Fatal exception trying to connect to rhost. Error:Failed to parse: 2620:10a:a001:a102::133 redfishtool:getCollection: Error getting service root, abortingcontroller-0:~$
 Verify cat /var/run/bmc/redfishtooémtcAgent_controller-1_root_query
  redfishtool:Transport: Fatal exception trying to connect to rhost. Error:Failed to parse: 2620:10a:a001:a102::138controller

 ping was successful
  ping6 2620:10a:a001:a102::133
PING 2620:10a:a001:a102::133(2620:10a:a001:a102::133) 56 data bytes
64 bytes from 2620:10a:a001:a102::133: icmp_seq=1 ttl=64 time=0.765 ms
64 bytes from 2620:10a:a001:a102::133: icmp_seq=2 ttl=64 time=0.402 ms
64 bytes from 2620:10a:a001:a102::133: icmp_seq=3 ttl=64 time=0.409 ms
64 bytes from 2620:10a:a001:a102::133: icmp_seq=4 ttl=64 time=0.389 ms
64 bytes from 2620:10a:a001:a102::133: icmp_seq=5 ttl=64 time=0.394 ms
64 bytes from 2620:10a:a001:a102::133: icmp_seq=6 ttl=64 time=0.380 ms

Severity
--------
Major

Steps to Reproduce
------------------
1. 1. Install system with configuration for BMC
2. 2. Verify redfishtool command as per cli.
3. 3. Verify cat /var/run/bmc/redfishtooémtcAgent_controller-1_root_query
  redfishtool:Transport: Fatal exception trying to connect to rhost. Error:Failed to parse: 2620:10a:a001:a102::138controller-0:/var/run/bmc/redfishtool$

Expected Behavior
------------------
Below Cli should be able to connect without failure. .
redfishtool -r "2620:10a:a001:a102::133" -u sysadmin -p Li69nux* Systems get

Actual Behavior
----------------
As per description it was failing below cli was failing.
redfishtool -r "2620:10a:a001:a102::133" -u sysadmin -p Li69nux* Systems get

Reproducibility
---------------
Reproducible 100%

System Configuration
--------------------
IPv6
Lab-name: wolfpass-13-14 and wolfpass 8-12

Branch/Pull Time/Commit
-----------------------
2019-11-11_20-00-00

Last Pass
---------
Never tested before

Timestamp/Logs
--------------
2019-11-13T15:10:58

Test Activity
-------------
Feature Testing

[Eric MacDonald (rocksolidmtce)]

No explicit IPV6 testing has been done with redfishtool by author that introduced the tool into the load nor myself.

Launching investigation into redfish support for IPV6 targets.

[Eric MacDonald (rocksolidmtce)]

Suggest PV continue redfish testing using IPV4.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/694608

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/694608
Committed: https://git.openstack.org/cgit/starlingx/metal/commit/?id=66e8fbd7476bae2e207fa7e1dac7623424d87173
Submitter: Zuul
Branch: master

commit 66e8fbd7476bae2e207fa7e1dac7623424d87173
Author: Eric MacDonald <email address hidden>
Date: Fri Nov 15 12:14:31 2019 -0500

    Add urlencoding to ip address for redfish requests

    This change applies to both IPv4 and IPv6 because
    the specification permits it.

    Test Plan:

    PASS: Verify for both IPv4 and IPv6 addressing
    PASS: Verify patched change for IPv4 and IPv6 cases.

    Change-Id: I99dcb31c51dd287eed8eb3a038a1814763a4c600
    Closes-Bug: #1852481
    Signed-off-by: Eric MacDonald <email address hidden>

[Anujeyan Manokeran (anujeyan)]

Verified in build 2019-11-18_20-00-00