Validate network configuration button selects all network scripts that accept an interface parameter

Bug #1852360 reported by Lee Trager
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Medium
Unassigned
maas-ui
Fix Released
Unknown

Bug Description

I updated a custom test script to MAAS. This script is a network script which accepts an interface parameter however it does not validate networking. When I selected 'Validate Network Configuration' on the network tab this script was automatically selected along with the built in connectivity tests.

The only scripts which should be automatically selected should be ones tagged "network-validation" regardless of whether they accept a network parameter. The builtin connectivity tests already have this tag applied.

Tags: ui
Revision history for this message
Lilyana Videnova (lilyanavidenova) wrote :

Is there a similar tag for the other types of tests?

Changed in maas:
assignee: nobody → Steve Rydz (steverydz)
Revision history for this message
Lee Trager (ltrager) wrote :

Every test is automatically tagged with its hardware type. e.g all storage tests have a storage tag, cpu a cpu tag etc. Any test which is tagged 'commissioning' will be automatically selected to run after commissioning. The UI also uses the 'commissioning' tag to determine which tests should be automatically selected when the testing dialog is shown.

Revision history for this message
Lilyana Videnova (lilyanavidenova) wrote :

We know that but what I meant was, in the new design of the summary page we have added separate links for ‘Test CPU / storage / memory’ (similarly to the network ones) that pre-select the tests of a given hardware type. Is there a different tag that we should use to base the pre-selecting of those off of?

Revision history for this message
Lee Trager (ltrager) wrote :

See the e-mail I sent out.

Changed in maas:
status: New → Triaged
Steve Rydz (steverydz)
Changed in maas:
assignee: Steve Rydz (steverydz) → nobody
Changed in maas-ui:
importance: Undecided → Unknown
Changed in maas-ui:
status: New → Fix Released
Changed in maas:
status: Triaged → Fix Committed
Changed in maas:
milestone: none → 3.3.0
Changed in maas:
milestone: 3.3.0 → 3.3.0-beta1
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.