Kicad: project manager not deleting entire dir when subdirs are present

Bug #1852357 reported by Mikołaj Wielgus
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Committed
Low
Ian McInerney

Bug Description

In project manager, when one deletes an entire directory that contains subdirectories, only non-directory files are (recursively) deleted; the directories (both the top- and sub- directories) are left intact, and an error is displayed (screenshot attached).

Either completely deleting the entire directory (including subdirectories) recursively or printing an error while having all files left intact are likely better options.

Application: KiCad
Version: (5.99.0-360-ga6b94b37e), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.66.0 OpenSSL/1.1.1d (Schannel) zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.39.2
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    Build date: Nov 13 2019 00:18:50
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.71.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.66.0
    Compiler: GCC 9.2.0 with C++ ABI 1013
Build settings:
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Revision history for this message
Mikołaj Wielgus (mwielgus) wrote :
Revision history for this message
Ian McInerney (imcinerney) wrote :

Yep, it looks like we need to delete the subfolders first.

Changed in kicad:
status: New → Triaged
milestone: none → 6.0.0-rc1
importance: Undecided → Low
Changed in kicad:
assignee: nobody → Ian McInerney (imcinerney)
status: Triaged → In Progress
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 88e55bbf2d868dfb350c3230db42268345fbee97
https://git.launchpad.net/kicad/patch/?id=88e55bbf2d868dfb350c3230db42268345fbee97

Changed in kicad:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.