Overrideable events at checkout should not be hard coded

[Michele Morgan]

There have been a few bugs related to overriding events in the web client during checkout and renewal:

bug 1781641 - Web Client: Cannot Override Patron Message Block

bug 1851434 - Web Client: Lost item renewal - COPY_NOT_AVAILABLE.override not consulted

bug 1827901 - Webby: Cannot override PATRON_EXCEEDS_LONGOVERDUE_COUNT (duplicate of 1851434)

These issues all stem from the hardcoding of overrideable events in this file:

Open-ILS/web/js/ui/default/staff/circ/services/circ.js

Overrideable events in Evergreen should be dynamic rather than a static list of events hardcoded in a file.

An example of why this is an issue ongoing, Evergreen supports the creation of penalty types via Local Administration -> Standing Penalties. Due to the hard coding of overrideable events, penalties added in this way and applied to patrons will not be overrideable.

[Ryan Eby (aadl-ubuntu)]

Ran into this today with AVAIL_HOLD_COPY_RATIO_EXCEEDED not being in the lists. There is a permission to override but staff are never given the option to do so.