Oslo db is logging exceptions before raising

[Darragh O'Reilly]

Customer sees and is concerned about errors (see attached) from oslo db in neutron server logs coming from:

https://github.com/openstack/oslo.db/blob/be28e3eaf7f96296d52db4e50837bbcfded9694f/oslo_db/sqlalchemy/exc_filters.py#L416-L418

Oslo db prints a stacktrace and raises an exception. Neutron handles it by retrying and there is no problem that operators need to know about.

https://opendev.org/openstack/neutron/commit/f21eed3998a793f5c40eb248469dc4245de3415a

IMO a library like oslo db should not be printing these errors. That should be the choice of clients like neutron when it handles the exception.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/693503

[Darragh O'Reilly (darragh-oreilly)]

Guidelines for logging:
https://specs.openstack.org/openstack/openstack-specs/specs/log-guidelines.html#stacktraces-in-logs

Stop spilling tracebacks during normal operation
https://opendev.org/openstack/neutron/commit/4f7fc8435f9340aae293bdcfef99201956ec2838

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/693503
Committed: https://git.openstack.org/cgit/openstack/oslo.db/commit/?id=cf6f1b43017826585c3b6c0528506cc533696131
Submitter: Zuul
Branch: master

commit cf6f1b43017826585c3b6c0528506cc533696131
Author: Darragh O'Reilly <email address hidden>
Date: Fri Nov 8 08:52:06 2019 +0000

    Reduce severity of wrapped exceptions logs to warning

    Change-Id: I6ea68fb17ceac23337bfb7405eb3f7a6df8b61f2
    Closes-Bug: 1851797

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/oslo.db 5.1.1 release.