EESchema - Title bar not updated when using find text

[Art]

If you search for a text in your schematic, the find function step you through all the instances on the current sheet and then will inform you that you reached the end of the schematic and it will wrap around if you keep going. It does it only for the current sheet, not the whole schematics. Now if you keep going it will start from the beginning of the current sheet and then will go through the whole schematic the second time around. I have "Search the current sheet only" unchecked when I attempt that

Application: KiCad
Version: (5.99.0-229-g5b8661f2a), release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.21.0 (+libidn2/2.1.1) nghttp2/1.34.0
Platform: Windows 8 (build 9200), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    Build date: Oct 16 2019 21:05:43
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Jeff Young (jeyjey)]

I can't reproduce this. Note that the search algorithm searches from the current selection (or start of the current sheet if there is no selection) to either the end of the schematic or the end of the current sheet (depending on whether or not "current sheet" is checked).

When it wraps around, it will go either to the beginning of the current sheet or the beginning of the schematic (again, depending on whether or not "current sheet" is checked).

[Michael Kavanagh (michaelkavanagh)]

I can't reproduce it either, but I did notice the sheet name in the title bar is not updated as you search (and traverse sheets). If you exit the Find dialog on a different sheet than when you started it still shows the wrong name.

[Art (diametrix)]

It appears to be fixed. I can't reproduce it in the latest verstion

[Ian McInerney (imcinerney)]

Great to hear Art. We should still fix the issue that Michael noticed in #2, so I will leave this bug for that one.

[Art (diametrix)]

Just ran across this issue again. If I search for any symbol that has been placed on the root sheet, while working on any other sheet I get the behavior described above - on the first attempt nothing is found and if I run it again, then it finds it

[Jeff Young (jeyjey)]

@Art, that's the designed behaviour. It's like a text editor: it searches from the current location to the end. If you hit find again it circles back around to the beginning.

[Art (diametrix)]

@Jeff

It is a bad designed behavior. Besides, what kind of text editors are you using?! All the ones I ever used either keep going in the loop or close the loop (go to the end and the from the top again to your current position)

When I search for a symbol in my schematic I'm not thinking what kind of hierarchical stricture of all my sheets is. If I search for a symbol and I'm told that nothing is found I assume that nothing is found. At the very least if you insist on doing a single pass, it should close the loop and come back to the same spot you started from, not to the top of the root sheet. That just doesn't make any sense.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 087a90cf999675940fdb113e76e96c660a1c84bb
https://git.launchpad.net/kicad/patch/?id=087a90cf999675940fdb113e76e96c660a1c84bb

[Ian McInerney (imcinerney)]

The fix I just pushed is only for the titlebar update issue identified in comment #2.