Hidden ratsnest reappears after routing track

[Enrico]

Sorry for the confusing summary, I have no idea how to describe it better.

If the rats nest is hidden and one draws a new wire but terminates it in the middle of nowhere, instead of connecting it to another pad/trace, a rats nest line appears although it's hidden. To show the rats nest line(s) while routing the track is very useful but it should disappear again after terminating the trace if the nest is hidden.
See attached GIF!

Kind of related to https://bugs.launchpad.net/kicad/+bug/1848488 (includes further discussion)

Application: KiCad
Version: 5.1.4-e60b266~84~ubuntu18.04.1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.58.0 OpenSSL/1.1.1 zlib/1.2.11 libidn2/2.0.4 libpsl/0.19.1 (+libidn2/2.0.4) nghttp2/1.30.0 librtmp/2.3
Platform: Linux 4.15.0-66-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.22
    Boost: 1.65.1
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.58.0
    Compiler: GCC 7.4.0 with C++ ABI 1011

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Fabien Corona (drinausaur)]

Patch proposal.

This patch applies to any BOARD_CONNECTED_ITEM the router lays on the board using PNS_KICAD_IFACE::AddItem. Therefore it also applies to vias (they were also affected )

[KiCad Janitor (kicad-janitor)]

Fixed in revision 6182133a4e9cf61548fb8ad49366185e978ac84d
https://git.launchpad.net/kicad/patch/?id=6182133a4e9cf61548fb8ad49366185e978ac84d

[Seth Hillbrand (sethh)]

Looks good. Thank you for your patch. It has been pushed to the master branch and we'll cherry-pick it back to 5.1.6 when the branch opens for low-priority commits.

[Ian McInerney (imcinerney)]

Cherry picked to 5.1 in 4130ce2b93c4e28815d6eaca6862f86fed0a49c5.

Note, a small change had to be made in the cherry pick since the ratsnest visibility is not stored in the display options in 5.1, it had to be gotten from the board object.