aodh-api service fails to start on xenial newton with SSL

[Liam Young]

When deploying aodh using the charms ssl-* params (as opposed to vault) the aodh-api service fails to start and the charm exposes this via workload status:

App Version Status Scale Charm Store Rev OS Notes
aodh 3.0.4 blocked 1 aodh jujucharms 98 ubuntu

Unit Workload Agent Machine Public address Ports Message
aodh/0* blocked idle 1 10.5.0.8 8042/tcp Services not running that should be: aodh-api

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/692369

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/692369
Committed: https://git.openstack.org/cgit/openstack/charm-aodh/commit/?id=5050885df955b9882fb0c249bb08688798a9f177
Submitter: Zuul
Branch: master

commit 5050885df955b9882fb0c249bb08688798a9f177
Author: Liam Young <email address hidden>
Date: Thu Oct 31 13:17:33 2019 +0000

    Do not rely on when_file_change for systemd reload

    Systemd was not relying being reloaded when the definition
    file for aodh-api changed. The reload was supposed to be
    triggered by the when_file_changed decorator. However,
    there are a number of issues with when_file_changed decorator (*1,
    *2, *3) and the decorator has now been deprecated *4.

    This change ensures the reload happens without relying on
    the decorator.

    *1 https://github.com/juju-solutions/charms.reactive/issues/25
    *2 https://github.com/juju-solutions/charms.reactive/issues/44
    *3 https://github.com/juju-solutions/charms.reactive/issues/49
    *4 https://github.com/juju-solutions/charms.reactive/issues/44#issuecomment-438472843

    Closes-Bug: #1850767

    Change-Id: I7c528a53a4de8a4a85bf655fc242b0f38fd0754b