Click and drag no longer works in the overview

[Owen Williams]

I'm used to going to the beginning of a track by clicking the overview and dragging all the way to the left. This has stopped working in recent builds of HEAD. It looks like there has been some recent work on the overview, was this either an inadvertent regression or an intentional change?

[ronso0 (ronso0)]

This was changed in https://github.com/mixxxdj/mixxx/pull/2238.
I think it's a regression. Didn't find a clue in the PR conversation why it was removed, also it doesn't interfere with left clicks as long as they aren't on a hotcue or range marker.

[ronso0 (ronso0)]

https://github.com/mixxxdj/mixxx/pull/2238/files?file-filters%5B%5D=.cpp&file-filters%5B%5D=.h&hide-deleted-files=true#diff-63372b146329ec67669d336bc0decfdaL337
(takes some time to load, it's huge diff)

[Owen Williams (ywwg)]

I agree, it looks like the rewrite dropped the concept of left-click and drag.

[Be (be.ing)]

This was changed intentionally, but I don't have a strong opinion about changing it back. My thinking was that seeking is time sensitive, so better to do it on button down than button up. If we change it back, it would be nice to allow the user to cancel the seek by pressing Esc before button up.

[Owen Williams (ywwg)]

Without this functionality there's no easy way to rewind a track -- the CUE marker might not be at the beginning. I'd prefer we first restore the behavior as it was before considering changes to how it works.

[Owen Williams (ywwg)]

I'm happy to reimplement the old behavior unless someone else is willing to do it -- I could also keep the first seek on mouse-down if latency is a worry. I'm not convinced of the utility of ESC to cancel a drag seek, I'd prefer to try it without that first and then we can test and add it in if necessary.

[Daniel Schürmann (daschuer)]

Oh sorry for hijacking this. I did not remember that you have applied for this.

[Daniel Schürmann (daschuer)]

https://github.com/mixxxdj/mixxx/pull/2353

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/9786