OVN: The ovn-nb-db-server and ovn-sb-db-server scripts don't handle schema updates

Bug #1850025 reported by Numan Siddique
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla
Fix Released
Medium
Numan Siddique
Ussuri
Fix Released
Medium
Numan Siddique

Bug Description

It is better to use ovn-ctl script [1] to start OVN ovsdb-servers as this script takes care of creating the database from the schema,
updating the database from the schema when the schema version gets updated.

This script is also used by OVN systemd services to start OVN services.

[1] - https://github.com/ovn-org/ovn/blob/master/utilities/ovn-ctl for newer OVN versions and https://github.com/openvswitch/ovs/blob/branch-2.11/ovn/utilities/ovn-ctl for older versions.

Changed in kolla:
assignee: nobody → Numan Siddique (numansiddique)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (master)

Fix proposed to branch: master
Review: https://review.opendev.org/691507

Mark Goddard (mgoddard)
Changed in kolla:
importance: Undecided → Medium
Changed in kolla:
assignee: Numan Siddique (numansiddique) → Radosław Piliszek (yoctozepto)
Changed in kolla:
assignee: Radosław Piliszek (yoctozepto) → Numan Siddique (numansiddique)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (master)

Reviewed: https://review.opendev.org/691507
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=b8c8fa15edcf5336a1121155cdc880a35ccf161f
Submitter: Zuul
Branch: master

commit b8c8fa15edcf5336a1121155cdc880a35ccf161f
Author: Numan Siddique <email address hidden>
Date: Sun Oct 27 12:35:47 2019 +0530

    Use ovn-ctl script to start OVN ovsdb-servers

    Using the ovn-ctl script to start the OVN ovsdb-server is the better
    way. This script is used to start and stop all OVN systemd services.
    This script takes care of creating the database from the schema,
    updating the database from the schema when the schema version gets
    updated.

    The present scripts - start_nb_db_server.sh and start_sb_db_server.sh
    doesn't take care of schema updates.

    With this, we don't need extend_start.sh in ovn-nb-db-server/ovn-sb-db-server
    to create the database from the schema.

    This patch also deletes kolla_ovn_extend_start from the ovn-base image as it
    is not required.

    Closes-bug: 1850025
    Change-Id: I31a372d801dace92950cd85b29b308431f78bbdb

Changed in kolla:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to kolla (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/694453

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla (stable/train)

Reviewed: https://review.opendev.org/694453
Committed: https://git.openstack.org/cgit/openstack/kolla/commit/?id=03668df367d3ed2aa82f6310f746d958a8a15f7e
Submitter: Zuul
Branch: stable/train

commit 03668df367d3ed2aa82f6310f746d958a8a15f7e
Author: Numan Siddique <email address hidden>
Date: Sun Oct 27 12:35:47 2019 +0530

    Use ovn-ctl script to start OVN ovsdb-servers

    Using the ovn-ctl script to start the OVN ovsdb-server is the better
    way. This script is used to start and stop all OVN systemd services.
    This script takes care of creating the database from the schema,
    updating the database from the schema when the schema version gets
    updated.

    The present scripts - start_nb_db_server.sh and start_sb_db_server.sh
    doesn't take care of schema updates.

    With this, we don't need extend_start.sh in ovn-nb-db-server/ovn-sb-db-server
    to create the database from the schema.

    This patch also deletes kolla_ovn_extend_start from the ovn-base image as it
    is not required.

    Closes-bug: 1850025
    Change-Id: I31a372d801dace92950cd85b29b308431f78bbdb
    (cherry picked from commit b8c8fa15edcf5336a1121155cdc880a35ccf161f)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla 9.0.0.0rc2

This issue was fixed in the openstack/kolla 9.0.0.0rc2 release candidate.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.