deployment fails due to 'ansible_processor' is undefined

[Alex Schultz]

Seems like we have fact or fact cachign problems. ansible_processor is defined in the zuul host-info so it does exist.

https://storage.bhs1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_aa6/688779/14/gate/tripleo-ci-centos-7-containers-multinode/aa6f3dd/job-output.txt

2019-10-25 18:28:28.529591 | primary | TASK [set-libvirt-type : Check cpu vendor] *************************************
2019-10-25 18:28:28.567183 | primary | Friday 25 October 2019 18:28:28 +0000 (0:00:04.053) 1:11:44.626 ********
2019-10-25 18:28:28.618380 | primary | fatal: [subnode-1]: FAILED! => {}
2019-10-25 18:28:28.618489 | primary |
2019-10-25 18:28:28.618548 | primary | MSG:
2019-10-25 18:28:28.618593 | primary |
2019-10-25 18:28:28.619246 | primary | The conditional check 'ansible_processor[1]|lower is search(item)' failed. The error was: error while evaluating conditional (ansible_processor[1]|lower is search(item)): 'ansible_processor' is undefined
2019-10-25 18:28:28.619300 | primary |
2019-10-25 18:28:28.619808 | primary | The error appears to be in '/home/zuul/workspace/.quickstart/usr/local/share/ansible/roles/set-libvirt-type/tasks/main.yml': line 2, column 3, but may
2019-10-25 18:28:28.620037 | primary | be elsewhere in the file depending on the exact syntax problem.
2019-10-25 18:28:28.620082 | primary |
2019-10-25 18:28:28.620279 | primary | The offending line appears to be:
2019-10-25 18:28:28.620334 | primary |
2019-10-25 18:28:28.620387 | primary | ---
2019-10-25 18:28:28.620497 | primary | - name: Check cpu vendor
2019-10-25 18:28:28.620563 | primary | ^ here

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/691425

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691425
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart-extras/commit/?id=4be84430e47dbd087cfccd37dea29d9444f43c9e
Submitter: Zuul
Branch: master

commit 4be84430e47dbd087cfccd37dea29d9444f43c9e
Author: Alex Schultz <email address hidden>
Date: Fri Oct 25 14:22:24 2019 -0600

    Collect hardware facts if necessary for libvirt type

    We're seeing failures where ansible_processor is missing. We should try
    to do a hardware fact collection if ansible_processor is not defined
    before executing the set-libvirt-type role tasks

    Change-Id: I40ae758d687dd8f637c27c0e7acf76dbf60adb51
    Closes-Bug: #1849895