deploy fails with ansible error when processing ContainerImageRegistryCredentials

Bug #1849747 reported by Alex Schultz
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Kevin Carter

Bug Description

Under stein

Setting ContainerImageRegistryCredentials and setting "push_destination: true" in the containers-prepare-parameter.yaml file lets the director download the images and store them on the director. If push_destination is not set, the login credentials are not used on the nodes unless "ContainerImageRegistryLogin: true" is also set. But when that parameter is set, you get the following error instead:

fatal: [overcloud-controller-0]: FAILED! => {"msg": "The conditional check 'container_registry_logins_json | length) > 0' failed. The error was: template error while templating string: unexpected ')'. String: {% if container_registry_logins_json | length) > 0 %} True {% else %} False {% endif %}\n\nThe error appears to be in '/var/lib/mistral/overcloud/Controller/host_prep_tasks.yaml': line 737, column 5, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n <email address hidden>: password\n - name: Convert logins json to dict\n ^ here\n"}

Revision history for this message
Alex Schultz (alex-schultz) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/691131

Changed in tripleo:
status: Triaged → In Progress
status: In Progress → Fix Released
milestone: ussuri-1 → train-rc1
assignee: nobody → Kevin Carter (kevin-carter)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/691131
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=94ea0b62265a6d835ae1dc1efb2099393be4a992
Submitter: Zuul
Branch: stable/stein

commit 94ea0b62265a6d835ae1dc1efb2099393be4a992
Author: Kevin Carter <email address hidden>
Date: Fri Sep 27 14:44:43 2019 -0500

    Add second fact to ensure type safty

    The logins json can be both a hash and a string, depending on how it is
    being set by the deployer. To ensure that we're able to cover both cases
    this change will test the initial data type and react accordingly.

    Closes-Bug: #1849747
    Change-Id: I443bc36ca8808e1547da37f207b011031120067f
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 51469aab2e1df785c8a42a53941754b74b33457c)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.6.2

This issue was fixed in the openstack/tripleo-heat-templates 10.6.2 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.