Warning if footprint has excessive pads

[Philipp Legrum]

For the Wishlist:

Whenever KiCAD associates pins of a part to pads of a footprint, it cannot determine if excess pads are intentional or due to a erratically assigned footprint (user error).

Hence, Pcbnew should emit a warning, if no one-to-one pin<->pad mapping can be established during read-in of the netlist.

...Something similar to what the attached patch is doing.

If pads are not in use by intention, (hidden) not connected pins should be present in library parts.

Application: Pcbnew
Version: (5.99.0-258-gdcfccd82d), release build
Libraries:
    wxWidgets 3.0.2
    libcurl/7.52.1 OpenSSL/1.0.2s zlib/1.2.8 libidn2/0.16 libpsl/0.17.0 (+libidn2/0.16) libssh2/1.7.0 nghttp2/1.18.1 librtmp/2.3
Platform: Linux 4.9.0-3-amd64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Sep 27 2019 18:39:13
    wxWidgets: 3.0.2 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.62.0
    OpenCASCADE Community Edition: 6.8.0
    Curl: 7.52.1
    Compiler: GCC 6.3.0 with C++ ABI 1010

Build settings:
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON
    KICAD_STDLIB_DEBUG=OFF
    KICAD_STDLIB_LIGHT_DEBUG=OFF
    KICAD_SANITIZE=OFF

[Nick Østergaard (nickoe)]

I think it alreado do warn you about this when importing the netlist.

[KiCad Janitor (kicad-janitor)]

Fixed in revision d788a5d99e6c3a8606663a6bc52c0a0d4a932073
https://git.launchpad.net/kicad/patch/?id=d788a5d99e6c3a8606663a6bc52c0a0d4a932073

[Seth Hillbrand (sethh)]

Looks good. I tested this and there was no previous warning but this made the extra, unassigned pads clear.

Thank you for your contribution to KiCad!

[Philipp Legrum (philulm)]

Thank you for accepting the patch. This warning can save lots of tears.