Mark items as damaged - changing fee usability issues

[Josh Stompro]

EG 3.3.4 Web Staff Client

Hello, we have found that changing the fee in the Mark Items Damaged pop up can be difficult to use.

The selection arrows that allow incrementing the value up and down work fine, it can just be tedious if you are changing from a $100 charge to a $12 charge.

Deleting the value to enter a new value isn't allowed. Once the last digit is deleted, the box flips back to the initial mark damaged screen and doesn't allow any action except for canceling.

Highlighting the value can work, but requires a lot of precision. If you accidentally move the mouse off to the left too far when selecting, out of the box, the whole box just closes.

Selecting the box, entering the new value then deleting the old value can also work, it just isn't intuitive.

It would be nice if deleting the value and entering a new value worked.

Here is a screencast showing what I'm seeing.
https://www.screencast.com/t/vwuAspvBiFa1

Josh

[Terran McCanna (tmccanna)]

This is still difficult to use in 3.4.

[Dan Briem (dbriem)]

Here's a branch for testing: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dbriem/lp1849370_mark_damage_modal_usability

The fee input removes itself when cleared because it's bound to same prop that conditionally renders the interface when it's not null.

The input is near the edge so the modal could accidentally close when drag selecting the input value to change it (the ui-bootstrap modal closes on mouseup over the backdrop, not just on click).

In testing I noticed if the cataloged item price is $0 the modal will keep reloading until you click the No Charge button. Also, if you otherwise charge a $0 fee without using the No Charge button, the user will end up being charged the full item price.

This branch uses a separate prop to conditionally render the interface, sets the modal backdrop prop to static, and handles the apply_fines param on submit just before the API call.

[Terran McCanna (tmccanna)]

Is this bug resolved with this fix? https://bugs.launchpad.net/evergreen/+bug/1827942

[Dan Briem (dbriem)]

Thanks for taking a look, Terran.

No, the other modal fix is for Angular. This is a specific Angular JS modal (and it addresses more than the backdrop prop).

[Terran McCanna (tmccanna)]

Ah, thank you, Dan!

[Terran McCanna (tmccanna)]

This works great for me, thanks Dan!

My signoff is at:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1849370_mark_damage_modal_usability_signoff

[Chris Sharp (chrissharp123)]

Pushed to master, 3.3 and 3.4. Thanks, Dan and Terran!