Drawing H/V/45 zones gives incorrect line previews

[Ian McInerney]

When drawing a zone that is constrained to H/V/45, the preview lines that show where the next line will go are very inconsistent and incorrect. See the attached screen recording for the examples.

Application: Pcbnew
Version: (5.1.4-113-gf2e75c96b), debug build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.65.3 OpenSSL/1.1.1c-fips zlib/1.2.11 brotli/1.0.7 libidn2/2.2.0 libpsl/0.20.2 (+libidn2/2.0.5) libssh/0.9.0/openssl/zlib nghttp2/1.38.0
Platform: Linux 5.1.18-300.fc30.x86_64 x86_64, 64 bit, Little endian, wxGTK
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 3.24
    Boost: 1.69.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.65.3
    Compiler: Clang 8.0.0 with C++ ABI 1002

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=ON
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=ON
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=ON
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Seth Hillbrand (sethh)]

I assume that you mean here that the 45/h/v limitation doesn't introduce extra lines to allow the zone sizing

[Ian McInerney (imcinerney)]

Yes, you don't get the actual preview lines appearing for the lines you are drawing on the screen. Also, it seems that the preview lines it draws are not correct either (see the one in the video where it drew 2 preview lines, one from each point already in the polygon).

[Seth Hillbrand (sethh)]

Fixed in revision bae50fab9

https://git.launchpad.net/kicad/patch/?id=bae50fab9