Position Relative To fails to switch between mm and inches

[Steve Matos]

In Pcbnew, when using the "Position Relative To..." option get's stuck in the first units used. This can either be mm or inches.

To Reproduce:
1. Open Pcbnew
2. Select inches for the current units
3. Click an existing pad... "Clearify Selection" comes up... select "Footprint"
4. Right click... select "Position Relative To..."
5. Dialog comes up and is correctly showing inches.
6. Click cancel to close dialog.
7. Change units to mm.
8. Repeat step 3 and 4.
9. Dialog now comes up with incorrect units. (i.e. still showing inches)

NOTE: The process works the same if you start with mm and then switch to inches. It seems to get stuck on whatever units you used first.

Application: Pcbnew
Version: (5.1.4)-1, release build
Libraries:
    wxWidgets 3.0.4
    libcurl/7.61.1 OpenSSL/1.1.1 (WinSSL) zlib/1.2.11 brotli/1.0.6 libidn2/2.0.5 libpsl/0.20.2 (+libidn2/2.0.5) nghttp2/1.34.0
Platform: Windows 7 (build 7601, Service Pack 1), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8)
    Boost: 1.68.0
    OpenCASCADE Community Edition: 6.9.1
    Curl: 7.61.1
    Compiler: GCC 8.2.0 with C++ ABI 1013

Build settings:
    USE_WX_GRAPHICS_CONTEXT=OFF
    USE_WX_OVERLAY=OFF
    KICAD_SCRIPTING=ON
    KICAD_SCRIPTING_MODULES=ON
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=ON
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=ON
    BUILD_GITHUB_PLUGIN=ON
    KICAD_USE_OCE=ON
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[KiCad Janitor (kicad-janitor)]

Fixed in revision 4813eb12e66b24aca0a6693d16d213141f7ad24c
https://git.launchpad.net/kicad/patch/?id=4813eb12e66b24aca0a6693d16d213141f7ad24c