Swift: reconfigure task fails when swift_has_replication_network is false

[Alexis Deberg]

The variable swift_has_replication_network is defined in defaults/main.yaml at
https://opendev.org/openstack/kolla-ansible/src/branch/master/ansible/roles/swift/defaults/main.yml#L72

If it evaluates to "true", then the following swift containers are started by the start.yml task:
- swift_account_replication_server
- swift_container_replication_server
- swift_object_replication_server

However, if it evaluates to "false", the mentioned containers are never started.

Then, the reconfigure task will fail when trying to get the state of the missing containers.

I believe in the reconfigure task, previously listed containers should be appended to the list only if swift_has_replication_network evaluates to true.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/689882

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/689882
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=9622ab96937dccea2f5b0d97ffc674ce10359cb7
Submitter: Zuul
Branch: master

commit 9622ab96937dccea2f5b0d97ffc674ce10359cb7
Author: Alexis Deberg <email address hidden>
Date: Mon Oct 21 17:46:35 2019 -0400

    Swift: compute the list of containers dynamically in the reconfigure task

    If swift_has_replication_network is false some containers do not exist on the
    target node.
    This commit adds steps to compute the final list of containers to act on.

    Change-Id: I12f8de53724c3f24832df83597f36f9614af8e75
    Closes-Bug: #1849189

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/693022

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/693022
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=f126ef93b3e5ff639a794b2a351559f6a9440cf9
Submitter: Zuul
Branch: stable/stein

commit f126ef93b3e5ff639a794b2a351559f6a9440cf9
Author: Alexis Deberg <email address hidden>
Date: Mon Oct 21 17:46:35 2019 -0400

    Swift: compute the list of containers dynamically in the reconfigure task

    If swift_has_replication_network is false some containers do not exist on the
    target node.
    This commit adds steps to compute the final list of containers to act on.

    Change-Id: I12f8de53724c3f24832df83597f36f9614af8e75
    Closes-Bug: #1849189
    (cherry picked from commit 9622ab96937dccea2f5b0d97ffc674ce10359cb7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 9.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 8.1.0 release.