openstack-integrator: type object 'LoadBalancer' has no attribute 'get_all'

[Adam Bell]

In a Juju deployment for openstack-integrator (version "rocky", rev 31), I came across the following stacktrace while trying to delete the charm:

Traceback (most recent call last):
  File "/var/lib/juju/agents/unit-openstack-integrator-0/.venv/lib/python3.6/site-packages/charms/reactive/__init__.py", line 74, in main
    bus.dispatch(restricted=restricted_mode)
  File "/var/lib/juju/agents/unit-openstack-integrator-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 379, in dispatch
    _invoke(hook_handlers)
  File "/var/lib/juju/agents/unit-openstack-integrator-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 359, in _invoke
    handler.invoke()
  File "/var/lib/juju/agents/unit-openstack-integrator-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 181, in invoke
    self._action(*args)
  File "/var/lib/juju/agents/unit-openstack-integrator-0/charm/reactive/openstack.py", line 129, in cleanup
    layer.openstack.cleanup()
  File "lib/charms/layer/openstack.py", line 143, in cleanup
    for lb in LoadBalancer.get_all():
AttributeError: type object 'LoadBalancer' has no attribute 'get_all'

Upon looking at the "LoadBalancer" class in the charm's lib/charms/layer/openstack.py file, it looks like there truly is no "get_all" method that was written for a "LoadBalancer".

[Edward Hope-Morley (hopem)]

Fix submitted for review - https://github.com/juju-solutions/charm-openstack-integrator/pull/25

[Edward Hope-Morley (hopem)]

Amendment to my original comment:

I also hit this when trying to figure out why LBs are not deleted when I destroy my k8s model. This needs fixing so that when a k8s model is destroyed we DO NOT leave the LBs behind.

[Edward Hope-Morley (hopem)]

Hi @tvansteenburgh can we please get a build of the charm (edge?) that includes this fix?

[Tim Van Steenburgh (tvansteenburgh)]

cs:~containers/openstack-integrator-45 is on edge currently, and will move to stable with the 1.17 release coming soon.

[Edward Hope-Morley (hopem)]

@tvansteenburgh -45 doesn't contain this fix unfortunately

[Tim Van Steenburgh (tvansteenburgh)]

Ahhh, right. Okay, will fix/rebuild and let you know.

[Edward Hope-Morley (hopem)]

@tvansteenburgh thanks just seen -46 that contains the fix

[Kevin W Monroe (kwmonroe)]

@Ed, yup, the stable branch of our fork (which is what this charm is built from) is now in sync with the upstream repo:

https://github.com/charmed-kubernetes/charm-openstack-integrator/tree/stable

You correctly found the newly built rev 46 that contains this fix. That's currently in edge/beta and will move to stable when 1.17 is released.