Upgrade from stein to train fails

[Liam Young]

Upgrading from stein to train fails with:

2019-10-17 06:48:38 INFO juju-log Check command not found: check_http
2019-10-17 06:48:38 INFO juju-log Nagios user not set up, nrpe checks not updated
2019-10-17 06:48:38 INFO juju-log Loaded template from templates/queens/consistencygroup.yaml
2019-10-17 06:48:38 INFO juju-log Rendering from template: /usr/share/openstack-dashboard/openstack_dashboard/conf/cinder_policy.d/consistencygroup.yaml
2019-10-17 06:48:38 DEBUG config-changed Traceback (most recent call last):
2019-10-17 06:48:38 DEBUG config-changed File "/var/lib/juju/agents/unit-openstack-dashboard-0/charm/hooks/config-changed", line 433, in <module>
2019-10-17 06:48:38 DEBUG config-changed main()
2019-10-17 06:48:38 DEBUG config-changed File "/var/lib/juju/agents/unit-openstack-dashboard-0/charm/hooks/config-changed", line 393, in main
2019-10-17 06:48:38 DEBUG config-changed hooks.execute(sys.argv)
2019-10-17 06:48:38 DEBUG config-changed File "/var/lib/juju/agents/unit-openstack-dashboard-0/charm/charmhelpers/core/hookenv.py", line 914, in execute
2019-10-17 06:48:38 DEBUG config-changed self._hooks[hook_name]()
2019-10-17 06:48:38 DEBUG config-changed File "/var/lib/juju/agents/unit-openstack-dashboard-0/charm/hooks/horizon_utils.py", line 398, in wrapped_f
2019-10-17 06:48:38 DEBUG config-changed f(*args, **kwargs)
2019-10-17 06:48:38 DEBUG config-changed File "/var/lib/juju/agents/unit-openstack-dashboard-0/charm/charmhelpers/contrib/hardening/harden.py", line 93, in _harden_inner2
2019-10-17 06:48:38 DEBUG config-changed return f(*args, **kwargs)
2019-10-17 06:48:38 DEBUG config-changed File "/var/lib/juju/agents/unit-openstack-dashboard-0/charm/hooks/config-changed", line 205, in config_changed
2019-10-17 06:48:38 DEBUG config-changed CONFIGS.write_all()
2019-10-17 06:48:38 DEBUG config-changed File "/var/lib/juju/agents/unit-openstack-dashboard-0/charm/charmhelpers/contrib/openstack/templating.py", line 334, in write_all
2019-10-17 06:48:38 DEBUG config-changed [self.write(k) for k in six.iterkeys(self.templates)]
2019-10-17 06:48:38 DEBUG config-changed File "/var/lib/juju/agents/unit-openstack-dashboard-0/charm/charmhelpers/contrib/openstack/templating.py", line 334, in <listcomp>
2019-10-17 06:48:38 DEBUG config-changed [self.write(k) for k in six.iterkeys(self.templates)]
2019-10-17 06:48:38 DEBUG config-changed File "/var/lib/juju/agents/unit-openstack-dashboard-0/charm/charmhelpers/contrib/openstack/templating.py", line 325, in write
2019-10-17 06:48:38 DEBUG config-changed with open(config_file, 'wb') as out:
2019-10-17 06:48:38 DEBUG config-changed FileNotFoundError: [Errno 2] No such file or directory: '/usr/share/openstack-dashboard/openstack_dashboard/conf/cinder_policy.d/consistencygroup.yaml'
2019-10-17 06:48:38 ERROR juju.worker.uniter.operation runhook.go:132 hook "config-changed" failed: exit status 1

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/689107

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/689107
Committed: https://git.openstack.org/cgit/openstack/charm-openstack-dashboard/commit/?id=5d9592ddca66ca14b6315e5abd534e0eeb157db4
Submitter: Zuul
Branch: master

commit 5d9592ddca66ca14b6315e5abd534e0eeb157db4
Author: Liam Young <email address hidden>
Date: Thu Oct 17 09:21:46 2019 +0000

    Correct resolve_CONFIGS force_update

    A typo in resolve_CONFIGS reveresed the desired behaviour so
    force_update=True would not force an update and vice versa.

    Change-Id: I4e19e7ab35f09f4e828632b4dc6074d2bd367356
    Closes-Bug: #1848440