Seed data doesn't indicate that the format.date and format.time library settings are deprecated

[Jane Sandberg]

Migration #1046 changed the label for the format.date ou setting from "Format Dates with this pattern." to "Deprecated: Format Dates with this pattern." (and similarly for format.time).

However, the Deprecated: prefix never made it into the seed data, so new systems don't show these settings as deprecated.

[Shula Link (slink-g)]

Confirmed that the label change does not exist in the seed data.

[Shula Link (slink-g)]

Will this require correction in the i18n seed values as well?

[Shula Link (slink-g)]

Possible fix here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=78a224d1d908d2ae27304ce747f2eb25c7db67dc

[Jeff Davis (jdavis-sitka)]

Is format.date actually deprecated? I understand that's the intention from bug 1691237, but it looks like eg-date-input still uses it. Maybe the setting is retrieved but ignored?

[Shula Link (slink-g)]

From what I could tell, it looks like there's a second label that specifies the yyyy-MM-dd format for format.date, as opposed to the label marked as deprecated which does not actually specify a date format.

[Jason Boyer (jboyer)]

Having looked at the current state of things The old format.date setting (I didn't bother to look for the time one) is still in use in the AJS client in at least offline.js and the ui service. The startup service uses the new settings.

What would be better than marking them deprecated in the seed data would be to complete the conversion to use the new settings everywhere, rename them in an upgrade script one more time if 'Deprecated:' isn't there, add a release note stating that they're no longer used and can be removed by admins at any time, and just remove them from the seed data altogether since no clients will use them going forward. This leaves them in existing databases if you're using them in local customizations, but there's no point in adding completely unused settings in new databases regardless of their name.

[Jason Boyer (jboyer)]

Since I suggested it: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1848398_fare_thee_well_format / working/user/jboyer/lp1848398_fare_thee_well_format

Does what I said above; move all AndularJS use of format.date to webstaff.format.dates (and I didn't see any use of format.time so that was a whole lot of nothing), remove the settings entirely from seed data, and set their deprecated-ness one last time if they have been missed in the past. Includes a release note telling admins they can remove them whenever they like, but they're left in place just in case they may be in use in a local customization.