Skins - cannot select header background image from folder

[Rangi Daymond]

- Code: 19.10_STABLE
- Browser tested: Chrome and Firefox
- Theme: Primary school and Raw

Preconditions:

1. A logged in site administrator (Admin) has at least one image in their home files folder and at least one sub-folder named 'images' with several image files in it.
2. A logged in student (Student) has at least one image in their home files folder and at least one sub-folder named 'images' with several image files in it.

Test steps: (repeat these for each browser/theme)

1. Admin creates a new site skin (Admin menu|Configure site|Skins--> Create skin ) and on the 'Page' tab attempts to select a file from the 'images' sub-folder. ✘
Actual result: (see Chrome attachment prefixed SS1) the folder cannot be opened to allow file selection in one action - at present a file can only be selected in one action if it is in the Home folder, otherwise Admin needs to double click the images folder name (this changes the folder but shuts the dialog window) then select the 'Add a file' button - it will now display the sub-folder content for selection however, the user cannot navigate back up to the parent folder.

2. Student creates a new public site skin (Main menu|Create|Skins--> Create skin ) and on the 'Page' tab attempts to select a file from the 'images' sub-folder. ✘
Actual result: (see Chrome attachment prefixed SS2) the student cannot open the folder to allow file selection (at all - not using two step approach as above) also, the layout of the selection modal is unusual.

[Kristina Hoeppner (kris-hoeppner)]

The modal being "unusual" is due to the fact that the description of one of the images does not contain any spaces. This is not anything that is going to be changed as we can either have word wrap or character wrap and usually word wrap is better.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10460

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10460
Committed: https://git.mahara.org/mahara/mahara/commit/63cfb9002b27c86590fde95fe5ae261736f1c16f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 63cfb9002b27c86590fde95fe5ae261736f1c16f
Author: Robert Lyon <email address hidden>
Date: Mon Oct 21 13:42:44 2019 +1300

Bug 1848096: Allow multi filebrowsers on one form

As we have 2 filebrowsers on the form using it's normal reply back
logic was not going to work.

Had to change it so that folder update updates the correct element

behatnotneeded

Change-Id: I24a1cdba65608a0328bd6db98840c62367975f1b
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10524

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10524
Committed: https://git.mahara.org/mahara/mahara/commit/b798a26cadd4e0185f8806f939acdd8a088cc659
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit b798a26cadd4e0185f8806f939acdd8a088cc659
Author: Robert Lyon <email address hidden>
Date: Mon Oct 21 13:42:44 2019 +1300

Bug 1848096: Allow multi filebrowsers on one form

As we have 2 filebrowsers on the form using it's normal reply back
logic was not going to work.

Had to change it so that folder update updates the correct element

behatnotneeded

Change-Id: I24a1cdba65608a0328bd6db98840c62367975f1b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 63cfb9002b27c86590fde95fe5ae261736f1c16f)