Mistral allows creating workflows with spaces in name but could not work with it

Bug #1848037 reported by Artem Lapin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mistral
Fix Released
High
Artem Lapin

Bug Description

We can create workflows definition with spaces in name, for example:

version: '2.0'
wf1:
  tasks:
    t1:
      workflow: name with spaces
name with spaces:
   tasks:
     t2:
       action: std.noop

But if we try to execute workflow "wf1" we get error, because Mistral tries to find subworkflow "name" instead of "name wit spaces", because Mistral defines "with spaces" as parameters for subworkflow "name". I propose prohibit the creation of workflow with spaces in the name.

Changed in mistral:
milestone: none → ussuri-1
importance: Undecided → High
Changed in mistral:
assignee: nobody → Artem Lapin (rimger)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to mistral (master)

Fix proposed to branch: master
Review: https://review.opendev.org/688876

Changed in mistral:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to mistral (master)

Reviewed: https://review.opendev.org/688876
Committed: https://git.openstack.org/cgit/openstack/mistral/commit/?id=f01d17726e145144d504173484cab4e5aa19abf3
Submitter: Zuul
Branch: master

commit f01d17726e145144d504173484cab4e5aa19abf3
Author: Artem Lapin <email address hidden>
Date: Wed Oct 16 11:40:38 2019 +0300

    Prohibit creation workflows with spaces in name

    Added additional check for workflow name to
    prevent creation workflows with spaces in
    name

    Change-Id: If52bd09f9178a1d6f2b0d476a43b25daa26a03be
    Closes-Bug: 1848037

Changed in mistral:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/mistral 10.0.0.0b1

This issue was fixed in the openstack/mistral 10.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.