Suppress privacy waiver entries when waiver not enabled

[Jeff Davis]

Privacy waiver entries are displayed in the patron summary whenever they exist, even if the working location doesn't use that feature. For example, suppose Library A uses privacy waivers and Library B does not. A patron from Library A visits Library B. Staff will see privacy waiver entries under "Allow others to use my account" in the patron summary, even though they don't use this feature. Likewise, the entries will continue to show at Library A even if they decide to turn off the feature.

The patron summary should check the circ.privacy_waiver org setting before displaying anything under "Allow others to use my account."

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1847922-hide-privacy-waiver-entries-when-disabled has a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1847922-hide-privacy-waiver-entries-when-disabled

[Jane Sandberg (sandbergja)]

Thanks for the branch, Jeff. It doesn't quite work, though. The waiver entries themselves aren't nested under the ng-if <div>, so they still show up even at orgs where circ.privacy_waiver is unset or false.

The only thing that currently is covered by the ng-if is the "Allow others to use my account" divider.

[Terran McCanna (tmccanna)]

Removing pullrequest as per comment #2