Change "Edit" icon on group category page

Bug #1847894 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Kristina Hoeppner

Bug Description

The "Edit" icon on the "Group categories" page in the admin area uses the "cog" icon instead of the "pencil-alt" icon even though the tool tip says "Edit". This should be changed for consistency.

To replicate:

1. As site admin, go to Admin menu -> Groups -> Group categories.
2. Add a group category.
Expected result: You see the pencil icon for the "Edit" icon.
Actual result: You see the cog icon, which we usually use for "Manage".

Since there is only the editing of the group category title possible and not managing other settings, it would be best to use the normal "Edit" icon.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10440

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10440
Committed: https://git.mahara.org/mahara/mahara/commit/0a130933c7e90374d60ba5ef865d3d343556f4da
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0a130933c7e90374d60ba5ef865d3d343556f4da
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Sun Oct 13 18:51:40 2019 +1300

Bug 1847894: Fix the edit icon on "Group categories"

This exchanges the "Manage" icon for the typical
"Edit" icon for consistency.

behatnotneeded

Change-Id: I60409a43e22d1a70fa67fecb816f98e05bd4b750

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10457

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10457
Committed: https://git.mahara.org/mahara/mahara/commit/26c9a1ce17e87d3a00e39b5b7b13d49940890ac3
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 26c9a1ce17e87d3a00e39b5b7b13d49940890ac3
Author: Kristina D.C. Hoeppner <email address hidden>
Date: Sun Oct 13 18:51:40 2019 +1300

Bug 1847894: Fix the edit icon on "Group categories"

This exchanges the "Manage" icon for the typical
"Edit" icon for consistency.

behatnotneeded

Change-Id: I60409a43e22d1a70fa67fecb816f98e05bd4b750
(cherry picked from commit 0a130933c7e90374d60ba5ef865d3d343556f4da)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.