pool-manager has been removed - deprecated since newton

[Corey Bryant]

Designate fails to deploy on Train because pool-manager has been removed:

https://opendev.org/openstack/designate/commit/52ad1c4c13d1fead646435634e4b07bb32c68d28

2019-10-11 13:07:38 DEBUG identity-service-relation-changed Traceback (most recent call last):
2019-10-11 13:07:38 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/charm/hooks/identity-service-relation-changed", line 22, in <module>
2019-10-11 13:07:38 DEBUG identity-service-relation-changed main()
2019-10-11 13:07:38 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/.venv/lib/python3.6/site-packages/charms/reactive/__init__.py", line 74, in main
2019-10-11 13:07:38 DEBUG identity-service-relation-changed bus.dispatch(restricted=restricted_mode)
2019-10-11 13:07:38 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 390, in dispatch
2019-10-11 13:07:38 DEBUG identity-service-relation-changed _invoke(other_handlers)
2019-10-11 13:07:38 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 359, in _invoke
2019-10-11 13:07:38 DEBUG identity-service-relation-changed handler.invoke()
2019-10-11 13:07:38 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/.venv/lib/python3.6/site-packages/charms/reactive/bus.py", line 181, in invoke
2019-10-11 13:07:38 DEBUG identity-service-relation-changed self._action(*args)
2019-10-11 13:07:38 DEBUG identity-service-relation-changed File "/var/lib/juju/agents/unit-designate-0/charm/reactive/designate_handlers.py", line 159, in sync_pool_manager_cache
2019-10-11 13:07:38 DEBUG identity-service-relation-changed instance.pool_manager_cache_sync()
2019-10-11 13:07:38 DEBUG identity-service-relation-changed File "lib/charm/openstack/designate.py", line 609, in pool_manager_cache_sync
2019-10-11 13:07:38 DEBUG identity-service-relation-changed subprocess.check_call(sync_cmd.split(), timeout=60)
2019-10-11 13:07:38 DEBUG identity-service-relation-changed File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
2019-10-11 13:07:38 DEBUG identity-service-relation-changed raise CalledProcessError(retcode, cmd)
2019-10-11 13:07:38 DEBUG identity-service-relation-changed subprocess.CalledProcessError: Command '['designate-manage', 'pool-manager-cache', 'sync']' returned non-zero exit status 2.

ubuntu@juju-c6afbc-coreycb2-10:~$ sudo designate-manage pool-manager-cache sync
usage: designate [-h] [--config-dir DIR] [--config-file PATH] [--debug]
                 [--log-config-append PATH] [--log-date-format DATE_FORMAT]
                 [--log-dir LOG_DIR] [--log-file PATH] [--nodebug]
                 [--nouse-journal] [--nouse-json] [--nouse-syslog]
                 [--nowatch-log-file]
                 [--syslog-log-facility SYSLOG_LOG_FACILITY] [--use-journal]
                 [--use-json] [--use-syslog] [--watch-log-file]
                 {database,pool,tlds} ...
designate: error: argument category: invalid choice: 'pool-manager-cache' (choose from 'database', 'pool', 'tlds')

[Corey Bryant (corey.bryant)]

Release notes: https://opendev.org/openstack/designate/src/commit/52ad1c4c13d1fead646435634e4b07bb32c68d28/releasenotes/notes/removed-pool-manager-a1a9466aceb44b9f.yaml

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/688124

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/688124
Committed: https://git.openstack.org/cgit/openstack/charm-designate/commit/?id=6a6d83327580252332a0b43d40e0d07f82bb8b0a
Submitter: Zuul
Branch: master

commit 6a6d83327580252332a0b43d40e0d07f82bb8b0a
Author: James Page <email address hidden>
Date: Fri Oct 11 14:28:52 2019 +0100

    Skip pool-manager-cache-sync for >= Rocky

    At Rocky, the use of the pool-manager service was dropped; ensure
    that the sync step is a no-op as at Train this command has also
    been removed and is no longer required if the pool-manager is not
    in use.

    Change-Id: If819c9abbff61134c2c689a5ab9f0872be937d34
    Closes-Bug: 1847767