[SRU] rocky fixes for watcher

[Stamatis Katsaounis]

[Impact]
Stamatis has reported that Watcher for Ubuntu Rocky needs the following patch: https://review.opendev.org/#/c/686110/

[Test Case]
Stamatis has committed to testing this SRU.

Stamatis, please can you fill in details on how you will verify this fixes the bug and doesn't regress the package?

[Regression Potential]
Regression potential is low. The patch has already landed upstream in the corresponding stable/rocky branch.

[Corey Bryant (corey.bryant)]

Hi Stamatis,

On Bionic, did you enable the cloud archive for Rocky?

sudo add-apt-repository cloud-archive:rocky
sudo apt update

http://reqorts.qa.ubuntu.com/reports/ubuntu-server/cloud-archive/rocky_versions.html

Thanks,
Corey

[Corey Bryant (corey.bryant)]

Comment #1 is no longer applicable as the bug has morphed into a patch cherry-pick for rocky.

[Stamatis Katsaounis (skatsaounis)]

Hi Corey,

Thank you for your comment. This is indeed the way to install OpenStack Rocky packages to Bionic Beaver. Unfortunately, the original problem is different than my initial bug report description. Sorry for that.

Our actual problem is that the current Watcher package 1.12.0 contains bugs and we cannot run our desired Watcher actions successfully. We managed to identify these bugs and we uploaded and merged a patch to upstream stable/rocky branch: https://review.opendev.org/#/c/686110/

With the aforementioned patch we managed to run Watcher successfully. The final request to the Ubuntu team is to include this bug-fix patch to a new Watcher package version 1.12.1 in order to help us run watcher installed by deb package, rather than source code.

[Corey Bryant (corey.bryant)]

Stamatis, I'm going to need your help on this. Can you help me figure out what patches are needed for Stein and Train packages? I'm actually really surprised the fix landed upstream with such a generic commit message and no related bug. The problem is that we have to fix Train and then Stein before we can fix Rocky, otherwise upgrades from Rocky to Stein will result in regressions for users.

[Corey Bryant (corey.bryant)]

To get the packages you can use:

pull-uca-source watcher train
pull-uca-source watcher stein
pull-uca-source watcher rocky

[Stamatis Katsaounis (skatsaounis)]

Hi Corey,

Sorry for my delayed response. I want to explain to you the situation. OpenStack Watcher team has made several refactoring to their code base and this fact makes things complicated.

For stable/rocky and only for this branch there is a bug which could not be handled the proper way. Being more specific, there is a patch which collects all issues which exist to current rocky release package. Notice that all of them have been solved to stein and train branches. On the other hand, they were solved inside big patches which are introducing big refactoring, thus, making them unable to be backported.

The patch that solves all of the for stable/rocky is the following: https://review.opendev.org/#/c/686110/

To prove that, I have gathered all the refactoring commits which solve them and could not be backported.

1. Move datasource to another directory:
https://github.com/openstack/watcher/commit/433eabb8d1cc9848b1043b66c75cd0898ed14b73
2. Fix avg to mean in a refactor:
https://github.com/openstack/watcher/commit/84cb589aa9294b95e026c9fa4a30daac704d0c8c
3. Initially change datasource to datasources:
https://github.com/openstack/watcher/commit/477b4d01e421a6fd7a1037f00539e8a79e92347e
4. Remove config datasources and receive it from global conf:
https://github.com/openstack/watcher/commit/bd8636f3f0622c18cfc6dd0f1698474a992da083

In addition to this patch rocky, stein and train packages are missing another bug fix which I am going to refer it to you: https://bugs.launchpad.net/watcher/+bug/1847434

As you can see the bug has been backported the proper way and this patch can be safely put into a bug fix package for all releases. These are the commit ids for each stable branch:

Stable/Train: e5884a963bf7239d6a0c580ef8f101834e7f3242
Stable/Stein: 306224f70cfa3adcd2e17ea5d88eff7cd37ac2a2
Stable/Rocky: a8974556ecc29f09e07f411fb745e61e68d8db92

I hope I made it clear to you and you can help with the bug fix release.

Best regards,
Stamatis

[Launchpad Janitor (janitor)]

[Expired for watcher (Ubuntu) because there has been no activity for 60 days.]