Search results for Mahara inbox search are displaying too close to search button

Bug #1847168 reported by Lisa Seeto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

The styling for the search results when searching through the messages of the Mahara Inbox notifications produces results displayed too close to the search button element (see attached screenshot) This may have happened during the bootstrap 4 upgrade.

Requirements:
- An inbox with at least one recieved notification OR an inbox with at least one 'sent'notification.

1. Log on to Mahara and click on the notifications icon in the header menu to be taken to the inbox.
2. In the search box enter in a string, i.e 'cat' and select 'Go'.
Expected results:
The results of the search are styled with adequate space to its surroundings
Actual results:
The results of the search are appearing too close to the button element.

Version: 19.10.dev and on 19.04 (Demo Mahara).

Revision history for this message
Lisa Seeto (lisaseeto) wrote :
Changed in mahara:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Evonne Cheung (evonne)
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

This requires some dev work. It also didn't look pretty in 18.10.

Evonne suggests to turn the options into tabs like we have on the Elasticsearch result screen outside of the search area. The tabs would site above "Bulk actions" and the type filter. We already have a filter on the page and putting another one on there would be a bit confusing.

Changed in mahara:
assignee: Evonne Cheung (evonne) → nobody
Changed in mahara:
milestone: 19.10rc1 → 19.10.0
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10439

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10439
Committed: https://git.mahara.org/mahara/mahara/commit/47196f0a6ee4877d1a4d6bc25bee6d77eb5c14f0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 47196f0a6ee4877d1a4d6bc25bee6d77eb5c14f0
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 11 16:46:10 2019 +1300

Bug 1847168: inbox search tabs styling

- same for outbox search

behatnotneeded

Change-Id: Idc308dc622e4a5f0fcf8a512713997a421b2c22d

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10454

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10454
Committed: https://git.mahara.org/mahara/mahara/commit/add64b597745176c1c5e11f97be895283db162ef
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit add64b597745176c1c5e11f97be895283db162ef
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Oct 11 16:46:10 2019 +1300

Bug 1847168: inbox search tabs styling

- same for outbox search

behatnotneeded

Change-Id: Idc308dc622e4a5f0fcf8a512713997a421b2c22d
(cherry picked from commit 47196f0a6ee4877d1a4d6bc25bee6d77eb5c14f0)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.