degrees of freedom wrong under strong simple structure

[Ben Goodrich]

example(Factanal)
## Reestimate SEFA model with strong simple structure requirement
df.residual(sefa) # wrong

The problem is that the degrees of freedom calculation is only based on the number of fixed elements in the coefficient matrix and the number of zeros in the zeros argument to FAiR_fix_coefficients in the FAiR/R/Utils.R file. Simple structure under Thurstone's definition requires at least one zero per row of the loading matrix. The model is estimated properly but the degrees of freedom do not reflect the extra zeros in the solution.

[Ben Goodrich (bgokgm)]

This problem also occurs when perfect clustering is requested. It is mostly fixed in the trunk; see

http://codebrowse.launchpad.net/~bgokgm/fair/trunk/revision/4

There is still a corner case in which simple structure or perfect clustering is insufficient to get the number of zeros the user requests into a particular factor. In that case the code will (correctly) squash more coefficients to zero but the degrees of freedom will not reflect this. A real fix will involve rechecking the degrees of freedom in the create_FAobject methods for restrictions.1storder, restrictions.general, and restrictions.2ndorder