pcbnew: netlist name not stored after netlist load

[Sergey A. Borshch]

steps to reproduce:
1) Open pcbnew in standalone mode
2) Choose File->Import->Netlist.
3) Choose netlist file.
4) Press "update pcb".
5) Close netlist loading dialog.
6) Open netlist loading dialog again.
Expected behavior: Last loaded netlist filename selected.
Actual behavior: Only path to netlist file directory displayed in file selection field. Actually there is path to last selected filename + filename from project file "LastNetListRead" option, which is NOT UPDATED after selecting and loading another file.

Version info: today's git master.
Application: Pcbnew
Version: (5.99.0-169-gce62941bb), release build
Libraries:
    wxWidgets 3.0.4
Platform: Linux 5.0.0-23-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Sep 29 2019 13:17:54
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.65.1
    Compiler: GCC 7.4.0 with C++ ABI 1011

Build settings:
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=OFF
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

[Rene Poeschl (poeschlr)]

offtopic (does not invalidate your report but might be helpful information anyways)

Are you aware of "tools->update pcb from schematic"? (The netlist import really only is of use if you get your netlist from an external tool not if you want to communicate between eeschema and pcb_new)

[Sergey A. Borshch (sb-sf)]

"tools->update pcb from schematic" not working in standalone mode, even if eechema opened from pcbnew and vise versa.

[Sergey A. Borshch (sb-sf)]

>The netlist import really only is of use if you get your netlist from an external tool
I need to manually edit netlist because of lp:1704083

[Wayne Stambaugh (stambaughw)]

It appears that there are two bugs here. The original reported bug and the fact that you can even run tools->update pcb from schematic when Pcbnew is run in the stand alone mode. This should be disabled when Pcbnew is run in single top (stand alone mode) or the schematic editor needs to be launched so the netlist can be read over a socket.

[Jeff Young (jeyjey)]

I think:

> "tools->update pcb from schematic" not working in standalone mode

just means it gives an error message (as it should). At least it does for me.

[KiCad Janitor (kicad-janitor)]

Fixed in revision 2679e8046913887f03d3504c9e7f602f559349a0
https://git.launchpad.net/kicad/patch/?id=2679e8046913887f03d3504c9e7f602f559349a0

[Sergey A. Borshch (sb-sf)]

Please check your fix - today's master build silently change xxxxxTextUpright in .pro file from 0 to 1. Or should I fill another bug report about this issue?

[Jeff Young (jeyjey)]

More likely a side-effect of my fix for https://bugs.launchpad.net/kicad/+bug/1843929, but I'll look into it.....

[Jeff Young (jeyjey)]

Nope; unrelated bug.

PS: the xxxxxTextUpright settings in the .pro file are red herrings -- they're no longer used in 6.0. The settings are now stored in the board file -- they're just initialised to the wrong value.

[Jeff Young (jeyjey)]

https://git.launchpad.net/kicad/commit/?id=6179dfde376481de3b47faf7867dff9c5ec221b2