pcbnew, netlist importer hangs if last bracket missed in netlist

Bug #1845848 reported by Sergey A. Borshch
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KiCad
Fix Released
Medium
Jeff Young

Bug Description

Steps to reproduce:
1) open eeschema, create schematics, File->Export->Export Netlist->Pcbnew->Export Netlist.
2) Open netlist file in text editor, remove trailing bracket, save file.
3) Open pcbnew, File->Import->Netlist, select netlist file.

Expected behavior: Error message about format violation.
Actual behavior: Application hangs with 100% CPU load.

Version info: today's git head:

Application: Pcbnew
Version: (5.99.0-169-gce62941bb), release build
Libraries:
    wxWidgets 3.0.4
Platform: Linux 5.0.0-23-generic x86_64, 64 bit, Little endian, wxGTK
Build Info:
    Build date: Sep 29 2019 13:17:54
    wxWidgets: 3.0.4 (wchar_t,wx containers,compatible with 2.8) GTK+ 2.24
    Boost: 1.65.1
    Compiler: GCC 7.4.0 with C++ ABI 1011

Build settings:
    KICAD_SCRIPTING=OFF
    KICAD_SCRIPTING_MODULES=OFF
    KICAD_SCRIPTING_PYTHON3=OFF
    KICAD_SCRIPTING_WXPYTHON=OFF
    KICAD_SCRIPTING_WXPYTHON_PHOENIX=OFF
    KICAD_SCRIPTING_ACTION_MENU=OFF
    BUILD_GITHUB_PLUGIN=OFF
    KICAD_USE_OCE=OFF
    KICAD_USE_OCC=OFF
    KICAD_SPICE=ON

Tags: pcbnew
Revision history for this message
Michael Kavanagh (michaelkavanagh) wrote :

Setting as Medium (not High/Critical) as this can be avoided by using the preferred "Update PCB from Schematic" route.

tags: added: pcbnew
Changed in kicad:
importance: Undecided → Medium
Revision history for this message
Jeff Young (jeyjey) wrote :

Bug is also in 5.1 (and 4.0, for that matter).

Changed in kicad:
milestone: none → 6.0.0-rc1
assignee: nobody → Jeff Young (jeyjey)
status: New → In Progress
milestone: 6.0.0-rc1 → 5.1.5
Revision history for this message
KiCad Janitor (kicad-janitor) wrote :

Fixed in revision 890e1c9ea0788108e92f0c317a95cc7338e1d853
https://git.launchpad.net/kicad/patch/?id=890e1c9ea0788108e92f0c317a95cc7338e1d853

Changed in kicad:
status: In Progress → Fix Committed
Changed in kicad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.