octavia deploy tasks fails when updating

Bug #1845366 reported by Brent Eagles
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
wes hayutin

Bug Description

https://review.opendev.org/#/c/672529/ the logic of whether or not to distribute cert info based on whether there was data or not. Since this information is no longer generated on update, it is not available and fails with:

fatal: [blaster]: FAILED! => {"msg": "The conditional check 'private_key_content|length > 0' failed. The error was: error while evaluating conditional (private_ke
y_content|length > 0): 'ansible.vars.hostvars.HostVarsVars object' has no attribute 'private_key_content'\n\nThe error appears to be in '/usr/share/ansible/roles/
octavia-controller-config/tasks/main.yml': line 7, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appear
s to be:\n\n\n- include_tasks: certificate.yml\n ^ here\n"}

Brent Eagles (beagles)
Changed in tripleo:
milestone: none → train-rc1
importance: Undecided → High
assignee: nobody → Brent Eagles (beagles)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)

Fix proposed to branch: master
Review: https://review.opendev.org/684826

Changed in tripleo:
status: New → In Progress
Changed in tripleo:
milestone: train-rc1 → ussuri-1
Changed in tripleo:
assignee: Brent Eagles (beagles) → wes hayutin (weshayutin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/684826
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=2cbe99b42950b385f2d4eb661d9f88ed5d2ef348
Submitter: Zuul
Branch: master

commit 2cbe99b42950b385f2d4eb661d9f88ed5d2ef348
Author: Brent Eagles <email address hidden>
Date: Wed Sep 25 15:34:56 2019 -0230

    Handle empty cert related hostvar info

    When certificates are neither generated nor provided (e.g. on update)
    related variables would be empty or undefined and need to be handled
    accordingly.

    Closes-Bug: #1845366
    Change-Id: I361c90e438e79e180e2a745da82e619347fed13e

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/687285

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/stein)

Reviewed: https://review.opendev.org/687285
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=de57975786f80b6aff8d3145071277c05359e79c
Submitter: Zuul
Branch: stable/stein

commit de57975786f80b6aff8d3145071277c05359e79c
Author: Brent Eagles <email address hidden>
Date: Tue Oct 8 10:02:50 2019 -0230

    Handle empty cert related hostvar info

    When certificates are neither generated nor provided (e.g. on update)
    related variables would be empty or undefined and need to be handled
    accordingly.

    Note: this file has been relocated to triple-ansible in train+ so this
    is a non-trivial backport of I361c90e438e79e180e2a745da82e619347fed13e.

    Change-Id: I6afe5078bd285374b3a9311a066ba10883c2ff66
    Closes-Bug: #1845366

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/687968

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-common (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/687969

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/queens)

Reviewed: https://review.opendev.org/687969
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=2dd5a9b790388232d2b7e01b2d5f1be793d706a4
Submitter: Zuul
Branch: stable/queens

commit 2dd5a9b790388232d2b7e01b2d5f1be793d706a4
Author: Brent Eagles <email address hidden>
Date: Tue Oct 8 10:02:50 2019 -0230

    Handle empty cert related hostvar info

    When certificates are neither generated nor provided (e.g. on update)
    related variables would be empty or undefined and need to be handled
    accordingly.

    Note: this file has been relocated to triple-ansible in train+ so this
    is a non-trivial backport of I361c90e438e79e180e2a745da82e619347fed13e.

    Change-Id: I6afe5078bd285374b3a9311a066ba10883c2ff66
    Closes-Bug: #1845366
    (cherry picked from commit de57975786f80b6aff8d3145071277c05359e79c)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-common (stable/rocky)

Reviewed: https://review.opendev.org/687968
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=97f3b8b010e7f63925b47af6b262038983763f01
Submitter: Zuul
Branch: stable/rocky

commit 97f3b8b010e7f63925b47af6b262038983763f01
Author: Brent Eagles <email address hidden>
Date: Tue Oct 8 10:02:50 2019 -0230

    Handle empty cert related hostvar info

    When certificates are neither generated nor provided (e.g. on update)
    related variables would be empty or undefined and need to be handled
    accordingly.

    Note: this file has been relocated to triple-ansible in train+ so this
    is a non-trivial backport of I361c90e438e79e180e2a745da82e619347fed13e.

    Change-Id: I6afe5078bd285374b3a9311a066ba10883c2ff66
    Closes-Bug: #1845366
    (cherry picked from commit de57975786f80b6aff8d3145071277c05359e79c)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 0.4.0

This issue was fixed in the openstack/tripleo-ansible 0.4.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common 10.8.2

This issue was fixed in the openstack/tripleo-common 10.8.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common rocky-eol

This issue was fixed in the openstack/tripleo-common rocky-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-common queens-eol

This issue was fixed in the openstack/tripleo-common queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.