Kubernetes dashboard tests passed when dashboard 404'd

[Mike Wilson]

The dashboard on 1.16 would 404 on the overview page and return you to the previous page. This wasn't caught in the tests because the test just verifies the return value is 200, which it is because you get a real page, but the page says 404. We need to find a way to detect this.

[Adam Stokes (adam-stokes)]

Can you point me to the line numbers where this test occurs? I can do some html parsing to make sure it has the proper page loaded

[Mike Wilson (knobby)]

This is what we do currently:

    async def dashboard_present(url):
        resp = await tools.requests.get(url, auth=auth, verify=False)
        if resp.status_code == 200 and "Dashboard" in resp.text:
            return True
        return False

https://github.com/charmed-kubernetes/jenkins/blob/master/jobs/integration/validation.py#L357

It seems the response has dashboard in it, but also a 404 and a redirect.