Angular: Local Admin Surveys Port

Bug #1845240 reported by Kyle Huckins
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Another Angular Local Admin port. We’ll be porting the Survey Admin UI from DOJO to Angular. This will be a grid with Add, Delete, Edit, and End options.

The grid should show Survey ID, Name, Description, Owning Library, Survey Start Date, End Date, and boolean OPAC Survey?, Poll Style?, Is Required?, and Display in User Summary? columns.

The name should be a link which directs you to edit the survey, which will be an fm-editor instance, followed by a Questions + Answers section below. The editor should have a button allowing you to end the survey, as well.

Mike Risher (mrisher)
Changed in evergreen:
assignee: nobody → Mike Risher (mrisher)
Revision history for this message
Mike Risher (mrisher) wrote :
Changed in evergreen:
assignee: Mike Risher (mrisher) → nobody
tags: added: pullrequest
Revision history for this message
Mike Risher (mrisher) wrote :

I made an adjust based on feedback. The editing page now has two tabs - one view is for editing survey info, and the other is for questions and answers.

Also, this has been rebased with the latest master.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=fec051caa3775bf6d8ac7b7e4c0439f8caaf32a3

Revision history for this message
Mike Risher (mrisher) wrote :
Bill Erickson (berick)
Changed in evergreen:
milestone: none → 3.5-alpha
status: New → Confirmed
importance: Undecided → Wishlist
Revision history for this message
Mike Risher (mrisher) wrote :

After seeing some of the feedback on previous work I cleaned up some code. Same branch:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mrisher/lp1845240-surveys

Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Mike. Interface worked as expected for me.

Sign-off branch pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1845240-surveys-signoff

NOTE to other testers/reviewers: The EG concerto data adds sample survey data with hard-coded ID's without bumping the table sequence values. This causes all survey creation to fail until you've made enough failed attempts to raise the sequences naturally or manually raised the sequences with SETVAL. I'll open a separate bug for this.

tags: added: signedoff
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Bill Erickson (berick) wrote :

Opened bug #1863929 for the concerto survey data issue.

Revision history for this message
Bill Erickson (berick) wrote :

Re-testing atop concerto fix in prep for master merge.

Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Looking good after concerto fixes. Able to create and modify surveys and their questions and answers. Thanks, Mike. Merged to master.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.