Thunar fails to scroll to the end of the file list

[Forest]

After upgrading from Ubuntu 18.04 to 19.04, Thunar's compact list view often fails to scroll the last column fully into view.

[Max-impulse (max-impulse)]

Buggy thunar 1.8.1. Does not display the entire file list.
Video:
https://www.youtube.com/watch?v=_KG-GslvxCI

[Alexxcons-x (alexxcons-x)]

Not sure what exactly is the problem. You cannot scroll to the very right side ? Sorry, I cannot reproduce the bug... for me all files are displayed.

What exactly you are doing / which keys are pressed ?
Does it happen in all your folders, or just in this one ?
Does it always happen for you, or only occassionally ?

May I ask you to provide a step-by step instruction to reproduce the bug ? I only can fix things which I can reproduce.

[Max-impulse (max-impulse)]

This happens in folders with a large number of files / folders and with long file / folder names.
Restarting thunar does not fix this.
Resizing the thunar corrects this.

There is a feeling that the thunar incorrectly calculates the size of the displayed field.
In the video, I'll show you how to catch the problem.

https://youtu.be/MJUQc01erGI

[Alexxcons-x (alexxcons-x)]

Still cannot reproduce the bug, tried to use many files, and olnly a single one with very long name.

You are using compact list view ? Does the bug as well show in icon view / detailed list view ?

Could you please try to provide a minimal reproducer ? ( e.g a minimal folder of empty files which already triggers the bug for you )

[Max-impulse (max-impulse)]

Yes, I use the compact list view
step-by step instruction to reproduce the bug:

https://youtu.be/oqX0kVQoTnA

[Alexxcons-x (alexxcons-x)]

Thanks for the reproducer ! But still no luck =( ... possibly the theme / icon theme matters ... which do you use ?

Will as well ask a friend to try to reproduce.

[Andreldm-2 (andreldm-2)]

That reproducer is really helpful and your instructions clear, but unfortunately I can't reproduce with neither Thunar 1.8.1 and 1.8.2.

This is what is did:
- Closing all thunar windows and killing its daemon with $ thunar -q
- $ mkdir ~/test; cd ~/test; for i in {1..200}; do mktemp -p ./ XXXXXXXXXXXXXX; done
- Starting thunar from terminal with $ thunar ~/test

This is my configuration:
- Compact List view at 38% (last-compact-view-zoom-level)
- Toolbar style location selector
- Thunar window size is 837x529 (last-window-width/last-window-height)
- Shortcuts sidebar separator is at 208 (last-separator-position
- Greybird theme from git
- Moka icon theme from git
- gtk 3.24.1

You can view those values in Settings Editor (xfce4-settings-editor).

[Max-impulse (max-impulse)]

Yes, it is a buggy style.
"Graybird" and "high contrast" in the xubuntu 18.10

[Andreldm-2 (andreldm-2)]

Now that you mentioned I'm able easily to reproduce this bug on a Xubuntu 18.10 VM, with Greybird and Adwaita.
Still no luck on my system.

[Theo Linkspfeifer (lastonestanding)]

If you play around with the height and width of the window, you should be able to trigger the bug with any theme.

[Theo Linkspfeifer (lastonestanding)]

The bug is the result of this change:

https://git.xfce.org/xfce/exo/commit/?id=928a41aedd1b64fea3c1adb7991ccb6c2c9f5870

[Andreldm-2 (andreldm-2)]

With Xubuntu 18.10 and 19.04 the bug is easily reproducible with Greybird and Adwaita.
With xfce-test, which is based on Xubuntu 18.10, I can't reproduce.

(In reply to Theo Linkspfeifer from comment #10)
> The bug is the result of this change:
>
> https://git.xfce.org/xfce/exo/commit/
> ?id=928a41aedd1b64fea3c1adb7991ccb6c2c9f5870

Did you bisect?
In any case it sounds suspect, since Sean reverted the part for preferred height calculation.

[Theo Linkspfeifer (lastonestanding)]

*** Bug 15629 has been marked as a duplicate of this bug. ***

[Forest (foresto)]

I can reproduce this as well. It started when I upgraded from Xubuntu 18.04 to 19.04.

$ dpkg-query --show thunar libexo-2-0
libexo-2-0:amd64 0.12.4-1
thunar 1.8.4-1ubuntu1

[Forest (foresto)]

Created attachment 9031
Revert the remaining change from 928a41ae

Reverting 928a41ae (the part that wasn't already reverted) appears to fix the problem. I'll test some more and post again if the problem returns.

[Forest (foresto)]

I've been using my patch for a couple days without seeing the problem again. Can someone merge it?

[Chris Guiver (guiverc)]

I just tried to replicate this bug on my 19.10 system, at first failing. On watching the video I switched from detailed-list to compact-list, moved to a directory with really long file names and when I shrunk the thunar window such that it didn't fit the longest lines - I could re-produce the bug (briefly). Switch windows (so thunar isn't active), and return and nope it's working perfectly.

I could re-produce it briefly. then failed to re-produce for soem time. Change thunar's width again (narrower than filenames require) and it occurs again, even when window is expanded so it'll fit.

Switch to the browser window to write more of this comment, return to thunar & it's working perfectly again.

guiverc@d960-ubu2:~$ apt-cache policy thunar
thunar:
  Installed: 1.8.9-1
  Candidate: 1.8.9-1
  Version table:
 *** 1.8.9-1 500
        500 http://ftp.iinet.net.au/pub/ubuntu eoan/universe amd64 Packages
        100 /var/lib/dpkg/status

[Gitbot (gitbot)]

Sean Davis referenced this bugreport in commit 2fa107272265b2ee1da4e39ab3c59e58a9a98436

Fix issues with displaying icon view contents (bug #14737)

https://git.xfce.org/xfce/exo/commit?id=2fa107272265b2ee1da4e39ab3c59e58a9a98436

[Bluesabre-1 (bluesabre-1)]

Patch applied above. Thanks everyone!

[Sean Davis (bluesabre)]

Fixed in exo 0.12.9. Focal has 0.12.11. Marking this ticket as resolved.