Swift role does not deploy multi-policies ring files

[Alexis Deberg]

Hello,

As of latest commit in master branch (3522d235bd13cf) the swift roles deploys the policies using a hardcoded list of ring files which prevents the deployment of a multi-policies cluster.

The hardcoded list is present in the following tasks:

- precheck.yml at https://opendev.org/openstack/kolla-ansible/src/commit/3522d235bd13cf689a3a3762d83fa190836f0572/ansible/roles/swift/tasks/precheck.yml#L104

- config.yml at https://opendev.org/openstack/kolla-ansible/src/commit/3522d235bd13cf689a3a3762d83fa190836f0572/ansible/roles/swift/tasks/config.yml#L186

A simple patch would be to use a variable that could be overwritten (but not named swift_ring_files which is already used in precheck.yml at https://opendev.org/openstack/kolla-ansible/src/commit/3522d235bd13cf689a3a3762d83fa190836f0572/ansible/roles/swift/tasks/precheck.yml#L103).

Unfortunately I'm not sure of the workflow to submit a patch but feel free to point me the right direction to do so.

[Mark Goddard (mgoddard)]

Hi Alexis, thanks for your bug report. It makes sense to me. It's quite a long doc, but here's the developer workflow: https://docs.openstack.org/infra/manual/developers.html. Feel free to ask for help on #openstack-kolla.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/683433

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/683433
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=0adbbb268e4f4c0c422fd6ac069dd202c1fefd05
Submitter: Zuul
Branch: master

commit 0adbbb268e4f4c0c422fd6ac069dd202c1fefd05
Author: Alexis Deberg <email address hidden>
Date: Fri Sep 20 11:46:36 2019 -0400

    Swift: add swift_extra_ring_files variable to handle multi-policies deployment

    The current tasks only use a hardcoded list deploying only the required files.
    When using multiple custom policies, additionnal object-*.builder and
    object*.gz files are to be deployed as well.
    This adds a new default-empty variable that can be overridden when needed

    Change-Id: I29c8e349c7cc83e3a2e01ff702d235a0cd97340e
    Closes-Bug: #1844752

[Alexis Deberg (adeberg)]

Looks like I forgot to update the config.json files and the files are not correctly copied inside the container.
Should I open a new distinct bug/commit or continue using this reference ?

[Mark Goddard (mgoddard)]

You can use this one if the fix is merged before the Train release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/691014

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/691014
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=5f4c71ee0f2b1c50675ab4241db89e81a3c27d86
Submitter: Zuul
Branch: master

commit 5f4c71ee0f2b1c50675ab4241db89e81a3c27d86
Author: Alexis Deberg <email address hidden>
Date: Thu Oct 24 12:24:27 2019 -0400

    Update swift templates to support swift_extra_ring_files

    Change-Id: Ie594f6cdbe332d64d3461d84da730111d0db5cf1
    Related-Bug: #1844752

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/kolla-ansible 9.0.0.0rc1 release candidate.